testbed: add and adopt WithEnvVar for child process #30491
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmfitzpatrick
force-pushed
the
testbedmaxprocs
branch
from
0e13f3f to
7582520
Compare
dmitryax
approved these changes
Jan 16, 2024
cparkins
pushed a commit
to AmadeusITGroup/opentelemetry-collector-contrib
that referenced
this pull request
Feb 1, 2024
…0491) **Description:** Adding a feature - These changes add a new `WithEnvVar` `ChildProcessOption` to be able to influence the child process environment without acting on the current environment. They also move the `GOMAXPROCS=2` setting added in open-telemetry@dd8e010 to each invoking test because though being helpful to address open-telemetry#27429, the constraint doesn't seem applicable to the helper directly. Limiting the utility as a whole instead of specifying in the test context cannot be easily worked around and is interfering w/ some load testing efforts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Adding a feature - These changes add a new
WithEnvVarChildProcessOptionto be able to influence the child process environment without acting on the current environment. They also move theGOMAXPROCS=2setting added in dd8e010 to each invoking test because though being helpful to address #27429, the constraint doesn't seem applicable to the helper directly. Limiting the utility as a whole instead of specifying in the test context cannot be easily worked around and is interfering w/ some load testing efforts.Testing:
Added unit test and updated existing.
Documentation:
none needed