[extension/oauth2clientauth] Remove duplicate validation logic #30469
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atoulme
force-pushed
the
oauth2clientauthextension_validation
branch
from
910c899 to
0375219
Compare
dmitryax
approved these changes
Jan 12, 2024
dmitryax
approved these changes
Jan 12, 2024
cparkins
pushed a commit
to AmadeusITGroup/opentelemetry-collector-contrib
that referenced
this pull request
Feb 1, 2024
…telemetry#30469) **Description:** remove the duplicate validation logic, use config.Validate instead.
This was referenced May 8, 2024
jpkrohling
pushed a commit
that referenced
this pull request
May 16, 2024
**Description:** Drop duplicate testing of parts related to TLS settings which already verified more extensively in other tests. This led to relevant changes requiring identical modifications in multiple places (e.g., #32332, #32394). Also remove 'TokenURL' and 'Scopes' from the corresponding configs as they are not required anymore (since #30469). For more details, see also #32623 (comment) Signed-off-by: Ilias Katsakioris <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
remove the duplicate validation logic, use config.Validate instead.