-
Notifications
You must be signed in to change notification settings - Fork 2.9k
[cmd/telemetrygen] Allow configuring Sum and Gauge metrics via CLI #26667
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
mx-psi
merged 22 commits into
open-telemetry:main
from
marcelbirkner:add-metrics-to-telemetrygen
Sep 18, 2023
Merged
Changes from all commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
407b67a
Add Sum and Histogram metrics
marcelbirkner 89c4a3f
Update metrics.go
marcelbirkner cd81db7
Update worker.go
marcelbirkner 2487539
Merge pull request #1 from marcelbirkner/extend-metrics
marcelbirkner 82537b4
Use status.code as attribute
marcelbirkner 2685e6b
Merge branch 'main' into add-metrics-to-telemetrygen
marcelbirkner a88abc8
Merge branch 'main' into add-metrics-to-telemetrygen
marcelbirkner 1f8f7b0
Merge branch 'main' into add-metrics-to-telemetrygen
marcelbirkner 910e588
Make metric-type configurable as a CLI parameter, remove metric attri…
marcelbirkner a2c96eb
Make metric-type configurable as a CLI parameter, remove metric attri…
marcelbirkner 13455a7
Keep Gauge as default metric type
marcelbirkner 9c36dd8
Update cmd/telemetrygen/internal/metrics/worker.go
marcelbirkner e49ae71
Update cmd/telemetrygen/internal/metrics/worker.go
marcelbirkner c000f9d
Removing Histograms and ALL, reverting metric name
marcelbirkner f92f7e9
Add changelog
marcelbirkner 9091f55
Add license header
marcelbirkner d6ddb63
gocritic: switch ifelse with case statement
marcelbirkner 4757222
Formattin
marcelbirkner 0fc8070
Fix unit tests
marcelbirkner 6a9c231
Merge branch 'main' into add-metrics-to-telemetrygen
marcelbirkner 5681037
Merge branch 'main' into add-metrics-to-telemetrygen
marcelbirkner 4e73213
Update cmd/telemetrygen/internal/metrics/worker.go
marcelbirkner File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,25 @@ | ||
# One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix' | ||
change_type: 'enhancement' | ||
|
||
# The name of the component, or a single word describing the area of concern, (e.g. filelogreceiver) | ||
component: cmd/telemetrygen | ||
|
||
# A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`). | ||
note: Add CLI option for selecting different metric types | ||
|
||
# Mandatory: One or more tracking issues related to the change. You can use the PR number here if no issue exists. | ||
issues: [26667] | ||
|
||
# (Optional) One or more lines of additional information to render under the primary note. | ||
# These lines will be padded with 2 spaces and then inserted directly into the document. | ||
# Use pipe (|) for multiline entries. | ||
subtext: | ||
|
||
# If your change doesn't affect end users or the exported elements of any package, | ||
# you should instead start your pull request title with [chore] or use the "Skip Changelog" label. | ||
# Optional: The change log or logs in which this entry should be included. | ||
# e.g. '[user]' or '[user, api]' | ||
# Include 'user' if the change is relevant to end users. | ||
# Include 'api' if there is a change to a library API. | ||
# Default: '[user]' | ||
change_logs: [user] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,36 @@ | ||
// Copyright The OpenTelemetry Authors | ||
// SPDX-License-Identifier: Apache-2.0 | ||
|
||
package metrics | ||
|
||
import ( | ||
"errors" | ||
) | ||
|
||
type metricType string | ||
mx-psi marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
const ( | ||
metricTypeGauge = "Gauge" | ||
metricTypeSum = "Sum" | ||
) | ||
|
||
// String is used both by fmt.Print and by Cobra in help text | ||
func (e *metricType) String() string { | ||
return string(*e) | ||
} | ||
|
||
// Set must have pointer receiver so it doesn't change the value of a copy | ||
func (e *metricType) Set(v string) error { | ||
switch v { | ||
case "Gauge", "Sum": | ||
*e = metricType(v) | ||
return nil | ||
default: | ||
return errors.New(`must be one of "Gauge" or "Sum"`) | ||
} | ||
} | ||
|
||
// Type is only used in help text | ||
func (e *metricType) Type() string { | ||
return "metricType" | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.