[exporter/signalfx] Remove temporary host translation workaround #2652
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This isn't needed anymore now that we're sending in `host.name`.
Codecov Report
@@ Coverage Diff @@
## main #2652 +/- ##
=======================================
Coverage 91.38% 91.39%
=======================================
Files 435 435
Lines 21595 21590 -5
=======================================
- Hits 19735 19732 -3
+ Misses 1396 1391 -5
- Partials 464 467 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
bogdandrutu
approved these changes
Mar 11, 2021
asuresh4
approved these changes
Mar 11, 2021
tigrannajaryan
approved these changes
Mar 11, 2021
kisieland
pushed a commit
to kisieland/opentelemetry-collector-contrib
that referenced
this pull request
Mar 16, 2021
Signed-off-by: Bogdan Drutu <[email protected]>
pmatyjasek-sumo
referenced
this pull request
in pmatyjasek-sumo/opentelemetry-collector-contrib
Apr 28, 2021
This isn't needed anymore now that we're sending in `host.name`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This isn't needed anymore now that we're sending in
host.name.