[cmd/telemetrygen] Add support for metric name/attributes #26506
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codeboten
reviewed
Sep 7, 2023
There was a problem hiding this comment.
Thanks for the contribution @claudiobastos! Would you be open to splitting adding the metric name option from adding telemetry attributes? It would speed up going through the review process
This reverts commit a971458.
…-attributes' into telemetrygen-signal-attributes
codeboten
approved these changes
Sep 14, 2023
|
|
@claudiobastos i gave it a shot, will see if i successfully merged things through the github UI without breaking anything 🤞🏻 The conflicting change that was merged was a documentation change. |
atoulme
reviewed
Sep 14, 2023
mx-psi
approved these changes
Sep 15, 2023
|
Oh... now we have more types for metrics \o/ |
|
Is there anything else I can do to improve this and allow merge ? @codeboten |
MovieStoreGuy
approved these changes
Sep 30, 2023
MovieStoreGuy
added
the
ready to merge
jmsnll
pushed a commit
to jmsnll/opentelemetry-collector-contrib
that referenced
this pull request
Nov 12, 2023
…etry#26506) **Description:** Add support to customize metric name and its attributes. **Link to tracking Issue:** open-telemetry#26505 **Testing:** - **Documentation:** self-documented in added flags --------- Signed-off-by: Claudio B <[email protected]> Co-authored-by: Alex Boten <[email protected]> Co-authored-by: Sean Marciniak <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Add support to customize metric name and its attributes.
Link to tracking Issue: #26505
Testing: -
Documentation: self-documented in added flags