[datadogexporter] Improve support of semantic conventions for K8s, Azure and ECS #2623
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2623 +/- ##
==========================================
+ Coverage 91.30% 91.32% +0.02%
==========================================
Files 429 430 +1
Lines 21457 21492 +35
==========================================
+ Hits 19591 19628 +37
+ Misses 1396 1395 -1
+ Partials 470 469 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
kisieland
pushed a commit
to kisieland/opentelemetry-collector-contrib
that referenced
this pull request
Mar 16, 2021
…mo/app (open-telemetry#2623) Signed-off-by: Bogdan Drutu <[email protected]>
It would conflict with the ECS hostname
KSerrania
reviewed
Mar 19, 2021
Comment on lines
+76
to
+80
| if ok && cloudProvider.StringVal() == conventions.AttributeCloudProviderAzure { | ||
| return azure.ClusterNameFromAttributes(attrs) | ||
| } else if ok && cloudProvider.StringVal() == conventions.AttributeCloudProviderAWS { | ||
| return ec2.ClusterNameFromAttributes(attrs) | ||
| } |
There was a problem hiding this comment.
I might not have followed everything here, is there a reason why we're not also doing this for GCP? Is it because there are no ways to get a cluster name from GCP-specific attributes?
There was a problem hiding this comment.
Yes, I should have mentioned it. There are none currently, there will be once #570 is resolved
mx-psi
commented
Mar 22, 2021
Co-authored-by: Kylian Serrania <[email protected]>
KSerrania
approved these changes
Mar 26, 2021
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
tigrannajaryan
approved these changes
Apr 9, 2021
pmatyjasek-sumo
referenced
this pull request
in pmatyjasek-sumo/opentelemetry-collector-contrib
Apr 28, 2021
…ure and ECS (#2623) TL;DR: - Add support for the new Azure resource detector - Improve support for Kubernetes semantic conventions - Improve support for Kubernetes labels - Improve support for ECS semantic conventions ### Azure - The `host.id` (Azure VM ID) is sent as a host alias now, to replicate the Datadog Agent behavior. - The cluster name is taken from the resource group ID. ### ECS - Task family, cluster ARN and task revision are mapped to Datadog conventions. `container.id` priority to be taken as a hostname is lowered since we only want this as a last resort. ### Kubernetes - OpenTelemetry Kubernetes semantic conventions are mapped to Datadog conventions. - Kubernetes labels conventions (both Datadog-specific and general recommendations) are mapped to Datadog conventions. - We now take the Kubernetes cluster name on Azure (see above) and AWS.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
TL;DR:
Azure
host.id(Azure VM ID) is sent as a host alias now, to replicate the Datadog Agent behavior.ECS
container.idpriority to be taken as a hostname is lowered since we only want this as a last resort.Kubernetes
Link to tracking Issue: n/a
Testing: Added unit tests