-
Notifications
You must be signed in to change notification settings - Fork 2.8k
feat: allow math expressions for time and duration #24453
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
TylerHelmuth
merged 18 commits into
open-telemetry:main
from
fchikwekwe:feat/math-time-duration
Aug 1, 2023
Merged
Changes from 15 commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
5466c52
feat: allow math expressions for time and duration
fchikwekwe f654024
doc: add changelog
fchikwekwe 31a1751
doc: update README to include math exprs for time and duration
fchikwekwe 71c455b
fix: allow duration first in dur ADD time
fchikwekwe 3011f61
fix: remove localization from test
fchikwekwe 0ea197e
Merge branch 'main' into feat/math-time-duration
fchikwekwe d5d463e
chore: make helper comply with linter
fchikwekwe 4a4ebf5
Merge branch 'feat/math-time-duration' of https://github.com/fchikwek…
fchikwekwe 440c80b
chore: use switch statements to comply with linter
fchikwekwe c8b7a40
chore: fix imports to comply with linter
fchikwekwe 67cf2fa
Update pkg/ottl/README.md
fchikwekwe ac8cd42
Update pkg/ottl/math.go
fchikwekwe d5357af
test: check for various errors
fchikwekwe 04e38aa
Merge branch 'feat/math-time-duration' of https://github.com/fchikwek…
fchikwekwe 7cea6f9
Merge branch 'main' into feat/math-time-duration
fchikwekwe b89fa55
Update pkg/ottl/README.md
fchikwekwe 5710f4a
Merge branch 'main' into feat/math-time-duration
fchikwekwe 9eaffec
Merge branch 'main' into feat/math-time-duration
fchikwekwe File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
# Use this changelog template to create an entry for release notes. | ||
# If your change doesn't affect end users, such as a test fix or a tooling change, | ||
# you should instead start your pull request title with [chore] or use the "Skip Changelog" label. | ||
|
||
# One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix' | ||
change_type: 'enhancement' | ||
|
||
# The name of the component, or a single word describing the area of concern, (e.g. filelogreceiver) | ||
component: 'pkg/ottl' | ||
|
||
# A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`). | ||
note: 'Add support for using addition and subtraction with time and duration' | ||
|
||
# Mandatory: One or more tracking issues related to the change. You can use the PR number here if no issue exists. | ||
issues: [22009] | ||
|
||
# (Optional) One or more lines of additional information to render under the primary note. | ||
# These lines will be padded with 2 spaces and then inserted directly into the document. | ||
# Use pipe (|) for multiline entries. | ||
subtext: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.