Skip to content

[fileconsumer] Move scanner into internal package #23999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 6, 2023
Merged

[fileconsumer] Move scanner into internal package #23999

merged 1 commit into from
Jul 6, 2023

Conversation

djaglowski
Copy link
Member

@djaglowski djaglowski commented Jul 5, 2023 •
edited
Loading

Follows #23998

Moves the PositionalScanner into an internal/scanner package.

@djaglowski djaglowski force-pushed the fileconsumer-internal-scanner branch from ba537e7 to 5fa2bb5 Compare July 5, 2023 20:56
@djaglowski djaglowski force-pushed the fileconsumer-internal-scanner branch from 5fa2bb5 to 4219e24 Compare July 6, 2023 00:47
@djaglowski djaglowski marked this pull request as ready for review July 6, 2023 03:03
@djaglowski djaglowski requested review from a team and dmitryax July 6, 2023 03:03
@codeboten codeboten merged commit 751c2e1 into open-telemetry:main Jul 6, 2023
@github-actions github-actions bot added this to the next release milestone Jul 6, 2023
@djaglowski djaglowski deleted the fileconsumer-internal-scanner branch July 6, 2023 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codeboten codeboten codeboten approved these changes

@dmitryax dmitryax Awaiting requested review from dmitryax

Assignees

@jpkrohling jpkrohling

Labels
pkg/stanza
Projects
None yet
Milestone
v0.82.0
Development

Successfully merging this pull request may close these issues.
3 participants
@djaglowski @codeboten @jpkrohling