Skip to content

[exporter/datadog] Use v0.3.0 of opentelemetry-mapping-go for logs tr… #23137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

IbraheemA
Copy link
Contributor

…anslation

Description:
translator.go was copied into the DataDog/opentelemetry-mapping-go repo in a previous PR, which is now available in the v0.3.0 release of that repo. Update the dependency version and replace imports of translator.go with the opentelemetry-mapping-go equivalent.

Testing: Tested with logs-appender example that sends logs and traces.

Documentation:

@IbraheemA IbraheemA requested a review from a team June 5, 2023 19:15
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jun 5, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: IbraheemA / name: Ibraheem Aboulnaga (364b585)
  • ✅ login: songy23 / name: Yang Song (917a081)

@github-actions github-actions bot added cmd/configschema configschema command cmd/otelcontribcol otelcontribcol command exporter/datadog Datadog components labels Jun 5, 2023
Copy link
Member

@songy23 songy23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please resolve the merge conflicts and add a changelog

@IbraheemA IbraheemA closed this Jun 5, 2023
@IbraheemA IbraheemA reopened this Jun 5, 2023
@IbraheemA IbraheemA force-pushed the otel-529-use-mapping-module branch from 50862ed to 364b585 Compare June 5, 2023 20:21
@IbraheemA IbraheemA requested a review from djaglowski as a code owner June 5, 2023 20:21
@github-actions github-actions bot requested a review from Mrod1598 June 5, 2023 20:22
@songy23 songy23 added dependencies Pull requests that update a dependency file ready to merge Code review completed; ready to merge by maintainers labels Jun 5, 2023
@codeboten codeboten merged commit b088ba8 into open-telemetry:main Jun 6, 2023
@github-actions github-actions bot added this to the next release milestone Jun 6, 2023
Caleb-Hurshman pushed a commit to observIQ/opentelemetry-collector-contrib that referenced this pull request Jul 6, 2023
…pen-telemetry#23137)

translator.go was copied into the DataDog/opentelemetry-mapping-go repo in a previous PR, which is now available in the v0.3.0 release of that repo. Update the dependency version and replace imports of translator.go with the opentelemetry-mapping-go equivalent.
---------

Co-authored-by: Yang Song <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cmd/configschema configschema command cmd/otelcontribcol otelcontribcol command dependencies Pull requests that update a dependency file exporter/datadog Datadog components ready to merge Code review completed; ready to merge by maintainers receiver/iis
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants