Skip to content

[pkg/ottl] Add new FloatLikeGetter and FloatGetter #21896

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 12, 2023

Conversation

TylerHelmuth
Copy link
Member

Description:
Adds new FloatLikeGetter and FloatGetter getters to facilitate float retrieval for functions who need floats.

Link to tracking Issue:
Related to #21825

Testing:
Added new tests

Documentation:
Added godoc strings

@TylerHelmuth TylerHelmuth requested a review from a team May 12, 2023 15:29
@github-actions github-actions bot requested a review from kentquirk May 12, 2023 15:30
Copy link
Contributor

@evan-bradley evan-bradley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good. If you add these to the function parser, I think we're good to go.

@TylerHelmuth TylerHelmuth merged commit 0e43390 into open-telemetry:main May 12, 2023
@TylerHelmuth TylerHelmuth deleted the ottl-floatlikegetter branch May 12, 2023 17:53
@github-actions github-actions bot added this to the next release milestone May 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants