[prometheusreceiver] enable reporting of additional metrics #21064
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…theus client used in PrometheusReceiver
|
|
|
@premendrasingh thx for your contributions, but you need to fix the CLA first. :-P |
|
Cancelling and resubmitting request to fix CLA. |
mx-psi
added a commit
that referenced
this pull request
Aug 1, 2023
(#21763) Feature: Enable reporting of additional metrics for Prometheus client used in PrometheusReceiver **Description:** Prometheus client has a featureFlag options.ExtraMetrics which reports content size metric ([scrape_body_size_bytes](https://github.com/prometheus/prometheus/blob/main/scrape/scrape.go#L1770)) for successful scrapes and -1 for dropped data. This metric will help us collect data and setup alert for dropped data. However the prometheus receiver does not have a way to enable this feature flag. This PR passes the flag to scrape.NewManager() to enable reporting of metric - [scrape_body_size_bytes](https://github.com/prometheus/prometheus/blob/main/scrape/scrape.go#L1770) **Link to tracking Issue:** #21040 **Testing:** Added check for validating the value set in testdata/config.yaml --------- Co-authored-by: Jared Tan <[email protected]> Co-authored-by: Pablo Baeyens <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature: Enable reporting of additional metrics for Prometheus client used in PrometheusReceiver
Description:
Prometheus client has a featureFlag options.ExtraMetrics which reports content size metric (scrape_body_size_bytes) for successful scrapes and -1 for dropped data. This metric will help us collect data and setup alert for dropped data. However the prometheus receiver does not have a way to enable this feature flag.
This PR passes the flag to scrape.NewManager() to enable reporting of metric - scrape_body_size_bytes
Link to tracking Issue:
#21040
Testing:
Added check for validating the value set in testdata/config.yaml