Remove redundant dependency on Jaeger collector #16370
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmitryax
requested review from
Aneurysm9,
dashpole,
jpkrohling and
mx-psi
as code owners
github-actions
bot
added
cmd/configschema
bogdandrutu
approved these changes
Nov 18, 2022
We used only one constant for error message from "github.com/jaegertracing/jaeger/cmd/collector/app/handler"
dmitryax
force-pushed
the
remove-jaeger-collector-dependency
branch
from
fbe4763 to
e21ab9a
Compare
JaredTan95
pushed a commit
to openinsight-proj/opentelemetry-collector-contrib
that referenced
this pull request
Nov 21, 2022
We used only one constant for error message from "github.com/jaegertracing/jaeger/cmd/collector/app/handler"
shalper2
pushed a commit
to shalper2/opentelemetry-collector-contrib
that referenced
this pull request
Dec 6, 2022
We used only one constant for error message from "github.com/jaegertracing/jaeger/cmd/collector/app/handler"
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We used only one constant for an error message from "github.com/jaegertracing/jaeger/cmd/collector/app/handler"