Skip to content

[exporter/kafka] move franz-go feature gate to stable, remove Sarama code #44565

@axw

Description

@axw

Component(s)

exporter/kafka

Describe the issue you're reporting

The franz-go feature gate has been in Beta since v0.135.0, I think it's had enough baking time to move it to Stable. I propose we do that, and give it 2 releases before removing the feature gate altogether.

const franzGoClientFeatureGateName = "exporter.kafkaexporter.UseFranzGo"
// franzGoClientFeatureGate is a feature gate that controls whether the Kafka exporter
// uses the franz-go client or the Sarama client. When enabled, the Kafka exporter
// will use the franz-go client, which is more performant and has better support for
// modern Kafka features.
var franzGoClientFeatureGate = featuregate.GlobalRegistry().MustRegister(
franzGoClientFeatureGateName, featuregate.StageBeta,
featuregate.WithRegisterDescription("When enabled, the Kafka exporter will use the franz-go client to produce messages to Kafka."),
featuregate.WithRegisterFromVersion("v0.128.0"),
)

Tip

React with 👍 to help prioritize this issue. Please use comments to provide useful context, avoiding +1 or me too, to help us triage it. Learn more here.

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions