[receiver/libhoney] requires / after paths #40070
Labels
Comments
mterhar
added
bug
|
Pinging code owners:
See Adding Labels via Comments if you do not have permissions to add labels yourself. |
codeboten
pushed a commit
that referenced
this issue
May 14, 2025
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description Adds a slash to the end of the `traces_url_paths:` so that libhoney appending datasets will always work regardless of whether the user adds the slash or not. <!-- Issue number (e.g. #1234) or full URL to issue, if applicable. --> #### Link to tracking issue Fixes #40070 <!--Describe what testing was performed and which tests were added.--> #### Testing curling a simple json object into the libhoney receiver to see that it doesn't return a 404 error. <!--Describe the documentation added.--> #### Documentation No changes to the documentation because it is handled in the configuration parser now. <!--Please delete paragraphs that you did not use before submitting.-->
seongpil0948
pushed a commit
to seongpil0948/opentelemetry-collector-contrib
that referenced
this issue
May 16, 2025
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description Adds a slash to the end of the `traces_url_paths:` so that libhoney appending datasets will always work regardless of whether the user adds the slash or not. <!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. --> #### Link to tracking issue Fixes open-telemetry#40070 <!--Describe what testing was performed and which tests were added.--> #### Testing curling a simple json object into the libhoney receiver to see that it doesn't return a 404 error. <!--Describe the documentation added.--> #### Documentation No changes to the documentation because it is handled in the configuration parser now. <!--Please delete paragraphs that you did not use before submitting.-->
johnleslie
pushed a commit
to johnleslie/opentelemetry-collector-contrib
that referenced
this issue
May 23, 2025
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description Adds a slash to the end of the `traces_url_paths:` so that libhoney appending datasets will always work regardless of whether the user adds the slash or not. <!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. --> #### Link to tracking issue Fixes open-telemetry#40070 <!--Describe what testing was performed and which tests were added.--> #### Testing curling a simple json object into the libhoney receiver to see that it doesn't return a 404 error. <!--Describe the documentation added.--> #### Documentation No changes to the documentation because it is handled in the configuration parser now. <!--Please delete paragraphs that you did not use before submitting.-->
johnleslie
pushed a commit
to johnleslie/opentelemetry-collector-contrib
that referenced
this issue
May 23, 2025
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description Adds a slash to the end of the `traces_url_paths:` so that libhoney appending datasets will always work regardless of whether the user adds the slash or not. <!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. --> #### Link to tracking issue Fixes open-telemetry#40070 <!--Describe what testing was performed and which tests were added.--> #### Testing curling a simple json object into the libhoney receiver to see that it doesn't return a 404 error. <!--Describe the documentation added.--> #### Documentation No changes to the documentation because it is handled in the configuration parser now. <!--Please delete paragraphs that you did not use before submitting.-->
dragonlord93
pushed a commit
to dragonlord93/opentelemetry-collector-contrib
that referenced
this issue
May 23, 2025
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description Adds a slash to the end of the `traces_url_paths:` so that libhoney appending datasets will always work regardless of whether the user adds the slash or not. <!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. --> #### Link to tracking issue Fixes open-telemetry#40070 <!--Describe what testing was performed and which tests were added.--> #### Testing curling a simple json object into the libhoney receiver to see that it doesn't return a 404 error. <!--Describe the documentation added.--> #### Documentation No changes to the documentation because it is handled in the configuration parser now. <!--Please delete paragraphs that you did not use before submitting.-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Component(s)
No response
What happened?
Description
If you don't include a
/after the paths, it will not treat them as wildcards and will not interpret the datasets properly. Every request gets a 404 error.Steps to Reproduce
use a config like this and see 400 errors:
Expected Result
It should take a request to /1/batch/{dataset} and process it.
Actual Result
Without the slash at the end of
- "/1/batch/, it will only process requests that go to /1/batch which is not how libhoney forms URLs.Collector version
v0.126.0
Environment information
Environment
OS: Docker
OpenTelemetry Collector configuration
Log output
curl -d '{"foo": "bar"}' http://127.0.0.1:8080/1/batch/dataset 404 page not foundAdditional context
No response
The text was updated successfully, but these errors were encountered: