ACL requirement for AWS S3 Exporter was a breaking change listed as Enhancement

[Erog38]

Component(s)

exporter/awss3

What happened?

Description

Starting in v0.121.0 Users are required to provide a valid ACL for bucket access. Many existing buckets don't support ACLs as a default. This means that we see errors as listed in the logs provided.

This will require a bucket configuration change and a collector change and as such needs to be mentioned as a breaking change.

Steps to Reproduce

1. Have or create S3 bucket without ACL support

2. Use provided configuration in any vanilla collector

3. Then use a tool such as telemetrygen to send:

telemetrygen logs \
    --duration 10m \
    --otlp-endpoint localhost:4317 \
    --otlp-insecure \
    --rate 100

Expected Result

Logs to show up in AWS S3

Actual Result

Error logs as attached.

Collector version

v0.123.0

Environment information

OpenTelemetry Collector configuration

receivers:
    otlp:
        protocols:
            grpc:
                endpoint: 0.0.0.0:4317
processors:
    batch:
        timeout: 10s
      memory_limiter:
        limit_percentage: 80
exporters:
      awss3
        s3uploader:
          region: us-east-1
          compression: gzip
          s3_bucket: $BUCKET
          s3_prefix: "some-prefix"
          role_arn: valid-arn
service:
    telemetry:
        pipelines:
            logs:
                receivers: [otlp]
                processors: [memory_limiter, batch]
                exporters: [awss3]

Log output

Exporting failed. Rejecting data. Try enabling sending_queue to survive temporary failures.
operation error S3: PutObject, https response error StatusCode: 400, RequestID: XXX, HostID: XXX, api error AccessControlListNotSupported: The bucket does not allow ACLs
Sender failed
operation error S3: PutObject, https response error StatusCode: 400, RequestID: XXX, HostID: XXX, api error AccessControlListNotSupported: The bucket does not allow ACLs

Additional context

No response

[github-actions]

Pinging code owners:

• exporter/awss3: @atoulme @pdelewski

See Adding Labels via Comments if you do not have permissions to add labels yourself.

[arianvp]

Many existing buckets don't support ACLs as a default

AWS explicitly recommends to disable ACLs on buckets https://docs.aws.amazon.com/AmazonS3/latest/userguide/ensure-object-ownership.html

If ACLs are mandatory to enable that sounds like a bug in the collector.

[basiljames]

The error AccessControlListNotSupported matches the AWS SDK API doc for attempting to set ACL for buckets that have ACL's disabled. Seems the acl attribute should be optional and not defaulted to private.