Skip to content

[pdatatest/pmetrictest] Introduce IgnoreExemplars, IgnoreExemplarSlice and ChangeDatapointAttributeValue to CompareMetricsOption #39004

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
odubajDT opened this issue Mar 27, 2025 · 1 comment · Fixed by #39005
Closed

[pdatatest/pmetrictest] Introduce IgnoreExemplars, IgnoreExemplarSlice and ChangeDatapointAttributeValue to CompareMetricsOption #39004

odubajDT opened this issue Mar 27, 2025 · 1 comment · Fixed by #39005
Labels
enhancement New feature or request needs triage New item requiring triage pkg/pdatatest

Comments

@odubajDT
Copy link
Contributor

odubajDT commented Mar 27, 2025 •
edited
Loading

Component(s)

pkg/pdatatest

Is your feature request related to a problem? Please describe.

CompareMetricsOption does not have the possibility to blur the values of exemplars, such as SpanID, TraceID or Timestamp, as it makes it impossible to compare metrics with these values are present. At the same time, the number of exemplars is not important in some cases, where it might be beneficial to ignore the number of exemplars.

Additionally, similary to ChangeResourceAttributeValue, it would be useful to have ChangeDatapointAttributeValue function to be able to mask attribute values in datapoints.

Describe the solution you'd like

Introducing IgnoreExemplars, IgnoreExemplarSlice and ChangeDatapointAttributeValue to CompareMetricsOption which will ignore the values present in exemplars

Describe alternatives you've considered

No response

Additional context

No response
@odubajDT odubajDT added enhancement New feature or request needs triage New item requiring triage labels Mar 27, 2025
@github-actions GitHub Actions
Copy link
Contributor

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@odubajDT odubajDT changed the title [pdatatest/pmetrictest] Introduce IgnoreSumExemplars to CompareMetricsOption [pdatatest/pmetrictest] Introduce IgnoreExemplars to CompareMetricsOption Mar 27, 2025
@odubajDT odubajDT mentioned this issue Mar 27, 2025
Merged
@github-actions github-actions bot mentioned this issue Apr 1, 2025
Closed
@odubajDT odubajDT changed the title [pdatatest/pmetrictest] Introduce IgnoreExemplars to CompareMetricsOption [pdatatest/pmetrictest] Introduce IgnoreExemplars, IgnoreExemplarSlice and ChangeDatapointAttributeValue to CompareMetricsOption Apr 1, 2025
@songy23 songy23 closed this as completed in e29d2f6 Apr 1, 2025
dmathieu pushed a commit to dmathieu/opentelemetry-collector-contrib that referenced this issue Apr 8, 2025
@odubajDT @dmathieu
[pkg/pdatatest] introduce IgnoreExemplars, IgnoreExemplarSlice and Ch…
fb64570 
…angeDatapointAttributeValue to CompareMetricsOption (open-telemetry#39005)

<!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. -->
#### Link to tracking issue
Fixes open-telemetry#39004

---------

Signed-off-by: odubajDT <[email protected]>
Fiery-Fenix pushed a commit to Fiery-Fenix/opentelemetry-collector-contrib that referenced this issue Apr 24, 2025
@odubajDT @Fiery-Fenix
[pkg/pdatatest] introduce IgnoreExemplars, IgnoreExemplarSlice and Ch…
6d5cb8d 
…angeDatapointAttributeValue to CompareMetricsOption (open-telemetry#39005)

<!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. -->
#### Link to tracking issue
Fixes open-telemetry#39004

---------

Signed-off-by: odubajDT <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request needs triage New item requiring triage pkg/pdatatest
Projects
None yet
Milestone
No milestone
1 participant
@odubajDT