-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Feature Request for Azure Monitor Metrics Data Plane Batch API Support #38651
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Pinging code owners:
See Adding Labels via Comments if you do not have permissions to add labels yourself. |
Thank you for this very detailed feature request. I'm actually planning to propose a PR from my fork that uses the getBatch API. This is the fork that we are using in my company for months already with good success! |
Hey @celian-garcia , glad to know that your company already using getBatch API It is same. Here is the go libraries for Batch API |
Ok we're actually using github.com/Azure/azure-sdk-for-go/sdk/monitor/query/azmetrics We followed this doc https://github.com/Azure/azure-sdk-for-go/blob/main/sdk%2Fmonitor%2Fquery%2FMIGRATION.md I was more asking for the dataplane API but I'm realising, reading again the doc that if we migrate to github.com/Azure/azure-sdk-for-go/sdk/monitor/query/azmetrics for everything, we should be good. Am I right? |
Hey @celian-garcia , yes, we are good and on right path, FYI : also mentioned doc you shared |
Also would you mind sharing the repo fork or pull request where this work is in progress. we also like to contribute to speedup the rollout |
Okay. Currently I want to finish this #37167 (multi subscription support) before to rebase and propose a PR from my fork's branch about getBatch I believe that it's the same for the azmetrics usage. I'd be glad to have your support on this! Can you just wait for the multi subscription config to be merged before starting to migrate to azmetrics. As otherwise we'd have some conflcts in tests. |
/label never-stale -needs-triage good-first-issue |
@celian-garcia Sounds good. I'll go through it. |
Yes we know it already and migrated from it to otel col. I don't remember why but I'd say that it's easier for us to code in Go and otel col is the perfect place to have it, benefiting also from a larger community. That could give us some ideas of improvements. though of course! For now, since we're using our fork now with quite a good result, I will focus on merging it as is but we take of course any feedback! |
I'm not very confident about this label, I remove it. /label -good-first-issue |
/label -good-first-issue |
@ashishbans I'm currently trying to add some tests for our fork that uses azmetrics package getBatch API. Is there any plan to have a fake API like other clients? |
Hey @celian-garcia , Glad to see we have made good progress on batchApi feature request. |
@ashishbans oh great ! I thought it would take time when I saw the milestone so I started today implement my own fake server haha 😂 |
Hey @celian-garcia |
Hello @celian-garcia , I wanted to check if there are any updates on this feature request. Thank you." |
I was waiting for another PR about subscription name label. Now it's merge so I can rebase. I will try to make it before the end of the week. |
…h API (#38895) <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description Let me introduce the Batch Metrics API https://learn.microsoft.com/en-us/rest/api/monitor/metrics-batch/batch?view=rest-monitor-2023-10-01&tabs=HTTP The advantages of using ``azmetrics`` batch metrics API over the ``armmonitor`` metrics API are described in details in the issue + in the README.md Note that this is a revival of a previous PR that we made last year, and that has not been followed up properly but we're using that forked code in the Amadeus company for months with good results. <!-- Issue number (e.g. #1234) or full URL to issue, if applicable. --> #### Link to tracking issue Relates #38651 <!--Describe what testing was performed and which tests were added.--> #### Testing ✅ Manual tests + mocked unit tests <!--Describe the documentation added.--> #### Documentation ✅ Added config field documentation in README.md <!--Please delete paragraphs that you did not use before submitting.--> Signed-off-by: Célian Garcia <[email protected]>
…h API (open-telemetry#38895) <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description Let me introduce the Batch Metrics API https://learn.microsoft.com/en-us/rest/api/monitor/metrics-batch/batch?view=rest-monitor-2023-10-01&tabs=HTTP The advantages of using ``azmetrics`` batch metrics API over the ``armmonitor`` metrics API are described in details in the issue + in the README.md Note that this is a revival of a previous PR that we made last year, and that has not been followed up properly but we're using that forked code in the Amadeus company for months with good results. <!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. --> #### Link to tracking issue Relates open-telemetry#38651 <!--Describe what testing was performed and which tests were added.--> #### Testing ✅ Manual tests + mocked unit tests <!--Describe the documentation added.--> #### Documentation ✅ Added config field documentation in README.md <!--Please delete paragraphs that you did not use before submitting.--> Signed-off-by: Célian Garcia <[email protected]>
…h API (open-telemetry#38895) <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description Let me introduce the Batch Metrics API https://learn.microsoft.com/en-us/rest/api/monitor/metrics-batch/batch?view=rest-monitor-2023-10-01&tabs=HTTP The advantages of using ``azmetrics`` batch metrics API over the ``armmonitor`` metrics API are described in details in the issue + in the README.md Note that this is a revival of a previous PR that we made last year, and that has not been followed up properly but we're using that forked code in the Amadeus company for months with good results. <!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. --> #### Link to tracking issue Relates open-telemetry#38651 <!--Describe what testing was performed and which tests were added.--> #### Testing ✅ Manual tests + mocked unit tests <!--Describe the documentation added.--> #### Documentation ✅ Added config field documentation in README.md <!--Please delete paragraphs that you did not use before submitting.--> Signed-off-by: Célian Garcia <[email protected]>
Hi @ashishbans, I believe that this PR #38895 is actually closing this issue. I will close it and let your reopen if needed. |
Okay I don't have rights to close 😄 |
/label -never-stale needs-triage |
Uh oh!
There was an error while loading. Please reload this page.
Component(s)
receiver/azuremonitor
Is your feature request related to a problem? Please describe.
Currently, the OpenTelemetry Collector's Azure integration uses the standard Azure Resource Manager (ARM) APIs for metrics collection, which has significant limitations:
Describe the solution you'd like
Implement support for the new Azure Monitor Metrics Data Plane API in the OpenTelemetry Collector. This API offers several significant advantages:
Describe alternatives you've considered
No response
Additional context
The Azure Monitor Metrics Data Plane API is Generally Available and represents a significant improvement in Azure monitoring capabilities. Key technical details:
The text was updated successfully, but these errors were encountered: