-
Notifications
You must be signed in to change notification settings - Fork 2.8k
[googlecloudmonitoring] config collection interval & more flexible metric filtering #36898
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Pinging code owners:
See Adding Labels via Comments if you do not have permissions to add labels yourself. |
A 5 minute interval was requested by the cloud monitoring team, so I don't think we should lower the default. Lower intervals can cause query performance problems. Better filtering makes sense. We should try and be consistent with other filtering-related configuration in collector components if we can, rather than invent something new here. |
Hi @dashpole
could you tell me where I can find the request? 5 minute interval means that the alert can delay at most 5 minutes, and I'm worried about that. |
I'm a Googler, so I reached out to them internally. @kjordy are there any details you can share here as to why a 5 minute interval is recommended for scraping ListTimeSeries? |
Is it possible to use a smaller interval restriction, like 1 minute? I also checked the documentation of Splunk SignalFx connection to GCP, the minimum poll rate can be 1 minute. ![]() |
hello , @kjordy, could you give extra information of the collection interval ? |
This is the response I got from the monitoring API team: This is a balance between freshness and QPS. This is also the default of many 3P vendors like Datadog. There are both costs and quotas associated with queries. Scraping at a low interval may be ok for a small number of metrics but is not recommended for doing bulk export. |
Hi @dashpole , thanks for the clarification, I understand the default interval setting now. I think maybe it's better to separate the default interval and the minimum interval settings ? Datadog has 5 min as default and 1 min as minimum: ![]() Now the default interval also serves as minimum limit: |
yeah, SGTM. Lets set a minimum of 1 minute. We should also document the costs of setting a lower interval. |
ok, I'll make a PR for it. |
@dashpole Regarding the " filtering-related configuration ", can you recommend one component that I can refer to implement this feature ? |
Ah, I didn't realize there was already a filter config in the monitoring API. We should just use our own configuration in that case. |
…37261) <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description <!-- Issue number (e.g. #1234) or full URL to issue, if applicable. --> #### Link to tracking issue Fixes part of #36898 <!--Describe what testing was performed and which tests were added.--> #### Testing <!--Describe the documentation added.--> #### Documentation <!--Please delete paragraphs that you did not use before submitting.-->
…pen-telemetry#37261) <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description <!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. --> #### Link to tracking issue Fixes part of open-telemetry#36898 <!--Describe what testing was performed and which tests were added.--> #### Testing <!--Describe the documentation added.--> #### Documentation <!--Please delete paragraphs that you did not use before submitting.-->
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description <!-- Issue number (e.g. #1234) or full URL to issue, if applicable. --> #### Link to tracking issue Fixes part of #36898 <!--Describe what testing was performed and which tests were added.--> #### Testing <!--Describe the documentation added.--> #### Documentation <!--Please delete paragraphs that you did not use before submitting.-->
…ry#37264) <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description <!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. --> #### Link to tracking issue Fixes part of open-telemetry#36898 <!--Describe what testing was performed and which tests were added.--> #### Testing <!--Describe the documentation added.--> #### Documentation <!--Please delete paragraphs that you did not use before submitting.-->
This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping Pinging code owners:
See Adding Labels via Comments if you do not have permissions to add labels yourself. |
…pen-telemetry#37261) <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description <!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. --> #### Link to tracking issue Fixes part of open-telemetry#36898 <!--Describe what testing was performed and which tests were added.--> #### Testing <!--Describe the documentation added.--> #### Documentation <!--Please delete paragraphs that you did not use before submitting.-->
This issue has been closed as inactive because it has been stale for 120 days with no activity. |
Component(s)
receiver/googlecloudmonitoring
Is your feature request related to a problem? Please describe.
Describe the solution you'd like
Describe alternatives you've considered
No response
Additional context
No response
The text was updated successfully, but these errors were encountered: