Skip to content

[googlecloudmonitoring] config collection interval & more flexible metric filtering #36898

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
chenlujjj opened this issue Dec 19, 2024 · 14 comments

Comments

@chenlujjj
Copy link
Contributor

Component(s)

receiver/googlecloudmonitoring

Is your feature request related to a problem? Please describe.

  1. The default collection interval is 5 mins, which is too large for monitoring
  2. The current metric filtering is not flexible enough, if we want to collect a bunch of metrics, the list would be too long

Describe the solution you'd like

  1. decrease the default collection interval
  2. enrich the metric filtering capabilities, such as include/exclude, regex, etc

Describe alternatives you've considered

No response

Additional context

No response

@chenlujjj chenlujjj added enhancement New feature or request needs triage New item requiring triage labels Dec 19, 2024
Copy link
Contributor

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@dashpole
Copy link
Contributor

A 5 minute interval was requested by the cloud monitoring team, so I don't think we should lower the default. Lower intervals can cause query performance problems.

Better filtering makes sense. We should try and be consistent with other filtering-related configuration in collector components if we can, rather than invent something new here.

@dashpole dashpole self-assigned this Dec 19, 2024
@dashpole dashpole removed the needs triage New item requiring triage label Dec 19, 2024
@chenlujjj
Copy link
Contributor Author

chenlujjj commented Dec 20, 2024

Hi @dashpole

A 5 minute interval was requested by the cloud monitoring team,

could you tell me where I can find the request? 5 minute interval means that the alert can delay at most 5 minutes, and I'm worried about that.

@dashpole
Copy link
Contributor

I'm a Googler, so I reached out to them internally. @kjordy are there any details you can share here as to why a 5 minute interval is recommended for scraping ListTimeSeries?

@chenlujjj
Copy link
Contributor Author

Is it possible to use a smaller interval restriction, like 1 minute?

I also checked the documentation of Splunk SignalFx connection to GCP, the minimum poll rate can be 1 minute.

image

@chenlujjj
Copy link
Contributor Author

hello , @kjordy, could you give extra information of the collection interval ?

@dashpole
Copy link
Contributor

This is the response I got from the monitoring API team:

This is a balance between freshness and QPS. This is also the default of many 3P vendors like Datadog. There are both costs and quotas associated with queries. Scraping at a low interval may be ok for a small number of metrics but is not recommended for doing bulk export.

@chenlujjj
Copy link
Contributor Author

chenlujjj commented Jan 15, 2025

Hi @dashpole , thanks for the clarification, I understand the default interval setting now.

I think maybe it's better to separate the default interval and the minimum interval settings ?

Datadog has 5 min as default and 1 min as minimum:

Image

Now the default interval also serves as minimum limit:
https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/main/receiver/googlecloudmonitoringreceiver/config.go#L31-L33

@dashpole
Copy link
Contributor

yeah, SGTM. Lets set a minimum of 1 minute. We should also document the costs of setting a lower interval.

@chenlujjj
Copy link
Contributor Author

ok, I'll make a PR for it.

@chenlujjj
Copy link
Contributor Author

We should try and be consistent with other filtering-related configuration in collector components if we can, rather than invent something new here.

@dashpole Regarding the " filtering-related configuration ", can you recommend one component that I can refer to implement this feature ?

@dashpole
Copy link
Contributor

Ah, I didn't realize there was already a filter config in the monitoring API. We should just use our own configuration in that case.

songy23 pushed a commit that referenced this issue Jan 16, 2025
…37261)

<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description

<!-- Issue number (e.g. #1234) or full URL to issue, if applicable. -->
#### Link to tracking issue
Fixes part of
#36898

<!--Describe what testing was performed and which tests were added.-->
#### Testing

<!--Describe the documentation added.-->
#### Documentation

<!--Please delete paragraphs that you did not use before submitting.-->
chengchuanpeng pushed a commit to chengchuanpeng/opentelemetry-collector-contrib that referenced this issue Jan 26, 2025
…pen-telemetry#37261)

<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description

<!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. -->
#### Link to tracking issue
Fixes part of
open-telemetry#36898

<!--Describe what testing was performed and which tests were added.-->
#### Testing

<!--Describe the documentation added.-->
#### Documentation

<!--Please delete paragraphs that you did not use before submitting.-->
songy23 pushed a commit that referenced this issue Feb 12, 2025
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description

<!-- Issue number (e.g. #1234) or full URL to issue, if applicable. -->
#### Link to tracking issue
Fixes part of
#36898

<!--Describe what testing was performed and which tests were added.-->
#### Testing

<!--Describe the documentation added.-->
#### Documentation

<!--Please delete paragraphs that you did not use before submitting.-->
khushijain21 pushed a commit to khushijain21/opentelemetry-collector-contrib that referenced this issue Feb 14, 2025
…ry#37264)

<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description

<!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. -->
#### Link to tracking issue
Fixes part of
open-telemetry#36898

<!--Describe what testing was performed and which tests were added.-->
#### Testing

<!--Describe the documentation added.-->
#### Documentation

<!--Please delete paragraphs that you did not use before submitting.-->
Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions github-actions bot added the Stale label Mar 18, 2025
zeck-ops pushed a commit to zeck-ops/opentelemetry-collector-contrib that referenced this issue Apr 23, 2025
…pen-telemetry#37261)

<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description

<!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. -->
#### Link to tracking issue
Fixes part of
open-telemetry#36898

<!--Describe what testing was performed and which tests were added.-->
#### Testing

<!--Describe the documentation added.-->
#### Documentation

<!--Please delete paragraphs that you did not use before submitting.-->
Copy link
Contributor

This issue has been closed as inactive because it has been stale for 120 days with no activity.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale May 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants