Skip to content

[configtls] Use configtls.NewDefaultClientConfig instead of manually creating struct #36064

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
51 tasks
mackjmr opened this issue Oct 29, 2024 · 2 comments · Fixed by #37565
Closed
51 tasks

[configtls] Use configtls.NewDefaultClientConfig instead of manually creating struct #36064

mackjmr opened this issue Oct 29, 2024 · 2 comments · Fixed by #37565
Labels
cmd/opampsupervisor

Comments

@mackjmr
Copy link
Member

mackjmr commented Oct 29, 2024 •
edited
Loading

Component(s)

No response

Describe the issue you're reporting

Move away from manually creating configtls.ClientConfig in favor of using configtls.NewDefaultClientConfig.

This is necessary for the following components:

  • cmd/opampsupervisor
  • exporter/alertmanagerexporter
  • exporter/coralogixexporter
  • exporter/datadogexporter
  • exporter/kafkaexporter
  • exporter/lokiexporter
  • exporter/opencensusexporter
  • exporter/otelarrowexporter
  • exporter/prometheusexporter
  • exporter/prometheuswriteexporter
  • exporter/rabbitmqexporter
  • exporter/signalfxexporter
  • exporter/splunkhecexporter
  • exporter/sumologicexporter
  • exporter/syslogexporter
  • exporter/zipkinexporter
  • extension/awsproxy
  • extension/httpforwardextension
  • extension/jaegerremotesampling
  • extension/oauth2clientauthextension
  • extension/opampextension
  • internal/aws/proxy
  • internal/kafka
  • pkg/datadog/config
  • processor/resourcedetectionprocessor
  • receiver/aerospikereceiver
  • receiver/awsxrayreceiver
  • receiver/bigipreceiver
  • receiver/cloudfoundryreceiver
  • receiver/couchdbreceiver
  • receiver/elasticsearchreceiver
  • receiver/flinkmetricsreceiver
  • receiver/httpcheckreceiver
  • receiver/kafkametricsreceiver
  • receiver/kafkareceiver
  • receiver/mongodbreceiver
  • receiver/mysqlreceiver
  • receiver/nginxreceiver
  • receiver/postgresqlreceiver
  • receiver/prometheusreceiver
  • receiver/rabbitmqreceiver
  • receiver/redisreceiver
  • receiver/riakreceiver
  • receiver/saphanareceiver
  • receiver/sapmreceiver
  • receiver/signalfxreceiver
  • receiver/simpleprometheusreceiver
  • receiver/solacereceiver
  • receiver/splunkhecreceiver
  • receiver/vcenterreceiver
  • testbed

Core collector issue: open-telemetry/opentelemetry-collector#11383
@mackjmr mackjmr added the needs triage New item requiring triage label Oct 29, 2024
@VihasMakwana
Copy link
Contributor

I'll help out with this.

This was referenced Nov 5, 2024
Closed
Closed
@github-actions github-actions bot mentioned this issue Nov 19, 2024
Closed
@github-actions github-actions bot mentioned this issue Nov 26, 2024
Closed
@github-actions github-actions bot mentioned this issue Dec 3, 2024
Closed
@atoulme atoulme added cmd/opampsupervisor and removed needs triage New item requiring triage labels Dec 9, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 9, 2024

Pinging code owners for cmd/opampsupervisor: @evan-bradley @atoulme @tigrannajaryan. See Adding Labels via Comments if you do not have permissions to add labels yourself. For example, comment '/label priority:p2 -needs-triaged' to set the priority and remove the needs-triaged label.

@VihasMakwana VihasMakwana mentioned this issue Dec 9, 2024
Merged
andrzej-stencel pushed a commit that referenced this issue Dec 16, 2024
@VihasMakwana
[chore][extension/awsproxy] use configtls.NewDefaultClientConfig (#36724
f8cfe87 
)

Relates
#36064
sbylica-splunk pushed a commit to sbylica-splunk/opentelemetry-collector-contrib that referenced this issue Dec 17, 2024
@VihasMakwana @sbylica-splunk
[chore][extension/awsproxy] use configtls.NewDefaultClientConfig (ope…
5e8d7ae 
…n-telemetry#36724)

Relates
open-telemetry#36064
mterhar pushed a commit to mterhar/opentelemetry-collector-contrib that referenced this issue Dec 19, 2024
@VihasMakwana @mterhar
[chore][extension/awsproxy] use configtls.NewDefaultClientConfig (ope…
9d0bdac 
…n-telemetry#36724)

Relates
open-telemetry#36064
AkhigbeEromo pushed a commit to sematext/opentelemetry-collector-contrib that referenced this issue Jan 13, 2025
@VihasMakwana @AkhigbeEromo
[chore][extension/awsproxy] use configtls.NewDefaultClientConfig (ope…
d28f9eb 
…n-telemetry#36724)

Relates
open-telemetry#36064
@odubajDT odubajDT mentioned this issue Jan 29, 2025
Merged
bogdandrutu pushed a commit that referenced this issue Jan 30, 2025
@odubajDT
[chore][cmd/opampsupervisor] use configtls.NewClientConfig() instead …
15ab161 
…of manually creating struct (#37565)

<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description

<!-- Issue number (e.g. #1234) or full URL to issue, if applicable. -->
#### Link to tracking issue
Fixes #36064

---------

Signed-off-by: odubajDT <[email protected]>
chengchuanpeng pushed a commit to chengchuanpeng/opentelemetry-collector-contrib that referenced this issue Feb 8, 2025
@odubajDT @chengchuanpeng
[chore][cmd/opampsupervisor] use configtls.NewClientConfig() instead …
eede613 
…of manually creating struct (open-telemetry#37565)

<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description

<!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. -->
#### Link to tracking issue
Fixes open-telemetry#36064

---------

Signed-off-by: odubajDT <[email protected]>
zeck-ops pushed a commit to zeck-ops/opentelemetry-collector-contrib that referenced this issue Apr 23, 2025
@VihasMakwana @zeck-ops
[chore][extension/awsproxy] use configtls.NewDefaultClientConfig (ope…
8c96ba0 
…n-telemetry#36724)

Relates
open-telemetry#36064
zeck-ops pushed a commit to zeck-ops/opentelemetry-collector-contrib that referenced this issue Apr 23, 2025
@odubajDT @zeck-ops
[chore][cmd/opampsupervisor] use configtls.NewClientConfig() instead …
87c1d3f 
…of manually creating struct (open-telemetry#37565)

<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description

<!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. -->
#### Link to tracking issue
Fixes open-telemetry#36064

---------

Signed-off-by: odubajDT <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cmd/opampsupervisor
Projects
None yet
Milestone
No milestone
3 participants
@atoulme @mackjmr @VihasMakwana