Skip to content

Prom rw translation, handle identical values in duplicate labels. #35896

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jmichalek132 opened this issue Oct 21, 2024 · 4 comments · Fixed by #36928
Closed

Prom rw translation, handle identical values in duplicate labels. #35896

jmichalek132 opened this issue Oct 21, 2024 · 4 comments · Fixed by #36928
Labels
exporter/prometheusremotewrite pkg/translator/prometheusremotewrite

Comments

@jmichalek132
Copy link
Contributor

jmichalek132 commented Oct 21, 2024 •
edited
Loading 

          I recall a recent issue around this... Should we only do this if the values are different?  I've seen cases where through various layers of translation the values get split and then merged and end up with `foo;foo` as the value.

Originally posted by @dashpole in #35751 (comment)

In append label value only if values are not identical.
https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/main/pkg/translator/prometheusremotewrite/helper.go#L134
@jmichalek132 jmichalek132 changed the title I recall a recent issue around this... Should we only do this if the values are different? I've seen cases where through various layers of translation the values get split and then merged and end up with foo;foo as the value. Prom rw translation, handle identical values in duplicate labels. Oct 21, 2024
@jmichalek132 jmichalek132 mentioned this issue Oct 21, 2024
Merged
@github-actions GitHub Actions
Copy link
Contributor

Pinging code owners for pkg/translator/prometheusremotewrite: @Aneurysm9 @dashpole. See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions GitHub Actions
Copy link
Contributor

Pinging code owners for exporter/prometheusremotewrite: @Aneurysm9 @rapphil @dashpole. See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions github-actions bot mentioned this issue Oct 22, 2024
Closed
@jmichalek132 jmichalek132 removed their assignment Dec 11, 2024
@jmichalek132
Copy link
Contributor Author

jmichalek132 commented Dec 11, 2024 •
edited
Loading

Hey @dashpole, could we please get this assigned to @avanish-vaghela, we chatted on slack and he was interested in implementing this easy fix.

@dashpole
Copy link
Contributor

I think it can only be assigned to otel members, but @avanish-vaghela, you can consider this yours to work on

This was referenced Dec 21, 2024
Closed
Merged
chengchuanpeng pushed a commit to chengchuanpeng/opentelemetry-collector-contrib that referenced this issue Jan 26, 2025
@avanish-vaghela @chengchuanpeng
[exporter/prometheusremotewrite] only append colliding attributes val…
93c4303 
…ues if they are different (open-telemetry#36928)

<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description

While translating two OTel attributes into Prometheus Labels, if both
attributes results in the same Prometheus label and both have the same
value, they won't be appended.

**Example:**
- "bar.one": "foo"
- "bar/one": "foo"

The above two attributes when translated to Prometheus label would
become
- Before the PR
    - "bar_one": "foo;foo"
- After the PR:
    - "bar_one": "foo"

<!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. -->
#### Link to tracking issue
Fixes open-telemetry#35896

<!--Describe what testing was performed and which tests were added.-->
#### Testing

- Unit test added

<!--Describe the documentation added.-->
#### Documentation
- Change log entry added 

<!--Please delete paragraphs that you did not use before submitting.-->
zeck-ops pushed a commit to zeck-ops/opentelemetry-collector-contrib that referenced this issue Apr 23, 2025
@avanish-vaghela @zeck-ops
[exporter/prometheusremotewrite] only append colliding attributes val…
4f412ff 
…ues if they are different (open-telemetry#36928)

<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description

While translating two OTel attributes into Prometheus Labels, if both
attributes results in the same Prometheus label and both have the same
value, they won't be appended.

**Example:**
- "bar.one": "foo"
- "bar/one": "foo"

The above two attributes when translated to Prometheus label would
become
- Before the PR
    - "bar_one": "foo;foo"
- After the PR:
    - "bar_one": "foo"

<!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. -->
#### Link to tracking issue
Fixes open-telemetry#35896

<!--Describe what testing was performed and which tests were added.-->
#### Testing

- Unit test added

<!--Describe the documentation added.-->
#### Documentation
- Change log entry added 

<!--Please delete paragraphs that you did not use before submitting.-->
This was referenced May 19, 2025
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
exporter/prometheusremotewrite pkg/translator/prometheusremotewrite
Projects
None yet
Milestone
No milestone
2 participants
@dashpole @jmichalek132