Preserve processor order in testbed Yaml config creator

[swamisriman]

Component(s)

testbed

Is your feature request related to a problem? Please describe.

In testbed scenarios.go, there is a function createConfigYaml(...) (ref) to get yaml config from given parameters.
As it takes the processor argument as a map, the processor order is not maintained.

This way, it's not possible to test scenarios where the processor order is important.

Describe the solution you'd like

Would be better if the function takes processors argument as an ordered data structure(say list).
or
The function may also take an additional argument with the list of processors (in the required order)

Describe alternatives you've considered

An alternate solution would be to get the config generated and then update the processors list to the required order

Additional context

No response

[github-actions]

Pinging code owners:

• testbed: @open-telemetry/collector-approvers

See Adding Labels via Comments if you do not have permissions to add labels yourself.

[crobert-1]

Good point, it should be ordered 👍 Thanks for calling this out!

[github-actions]

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

• testbed: @open-telemetry/collector-approvers

See Adding Labels via Comments if you do not have permissions to add labels yourself.

[swamisriman]

Hi @crobert-1

Any suggestions on the solution?
I can raise a PR.

[crobert-1]

Hi @crobert-1

Any suggestions on the solution? I can raise a PR.

Since a map is inherently unordered, I'd start with trying to understand if a map in this case is absolutely required. If not, we should try to move to using an ordered type, like an array. I'm not very familiar with the internal logic of the testbed, so that's as much information as I have at this point.

A PR is welcome!

[swamisriman]

Yeah...if we are open to changing the datatype, we can go with a 2D string array.
I don't think this will affect any internal working of the testbed. This is just used to supply the config.
But for those who are already using this function, it will break.