Skip to content

[receiver/datadog] span.Resource is dropped #23150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
hughsimpson opened this issue Jun 6, 2023 · 4 comments · Fixed by #23814
Closed

[receiver/datadog] span.Resource is dropped #23150

hughsimpson opened this issue Jun 6, 2023 · 4 comments · Fixed by #23814
Labels
bug Something isn't working receiver/datadog

Comments

@hughsimpson
Copy link
Contributor

Component(s)

receiver/datadog

What happened?

Description

As of pr 21764 the datadog receiver drops the span.Resource field - since this is where dd-java-agent put the db.statement field, this means that db statements are no longer available

Steps to Reproduce

Instrument an application with dd apm, and check any db span

Expected Result

span.Resource should be available as a tag on spans

Actual Result

span.Resource is not available as a tag on spans

Collector version

v0.78.0

Environment information

Environment

N/A

OpenTelemetry Collector configuration

N/A

Log output

No response

Additional context

No response
@hughsimpson hughsimpson added bug Something isn't working needs triage New item requiring triage labels Jun 6, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jun 6, 2023

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@hughsimpson hughsimpson changed the title [datadog/receiver] span.Resource is dropped [receiver/datadog] span.Resource is dropped Jun 6, 2023
@boostchicken
Copy link
Member

I'll get to this early next week.

@MovieStoreGuy
Copy link
Contributor

Thanks @boostchicken ,

From what I can tell is that dd.span.Resource needs to be added as a field.

@hughsimpson hughsimpson mentioned this issue Jun 28, 2023
Merged
@hughsimpson
Copy link
Contributor Author

I got around to it myself here #23814

@andrzej-stencel andrzej-stencel removed the needs triage New item requiring triage label Jun 29, 2023
jpkrohling pushed a commit that referenced this issue Jul 26, 2023
@hughsimpson
[receiver/datadog]: Fix #23150 (missing span.Resource) (#23814)
b847fe7 
**Description:**
Fixes
#23150
by include the original `dd.span.Resource` in the attributes of the
translated span

**Link to tracking Issue:**
[23150](#23150)

**Testing:** Added test that span.Resource is included in translate
attributes

**Documentation:** Added note on `dd.span.Resource` to datadog receiver
README
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working receiver/datadog
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[receiver/datadog]: Fix #23150 (missing span.Resource) hughsimpson/opentelemetry-collector-contrib
4 participants
@boostchicken @hughsimpson @MovieStoreGuy @andrzej-stencel