-
Notifications
You must be signed in to change notification settings - Fork 2.8k
[pkg/ottl] Update contexts so that all time fields Getters return time.Time
and Setters take time.Time
#22010
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
time.Time
and Setters take time.Time
. The accessor names should be updated to drop the time precision (_nano
).time.Time
and Setters take time.Time
Just hit this with newly introduced in 0.81.0 Time() converter when wanted to convert some fields from k8s events to Timestamp to send event logs to ElasticSearch
Looking forward to it! |
@ptimofee FYI the Unix nano paths haven't been updated to accept Times yet, they still expect integers. See the main tracking issue for progress on tying all this together. |
Nevermind, I see we are on the issue asking for this capability. Yes, we're working towards it. |
This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping Pinging code owners:
See Adding Labels via Comments if you do not have permissions to add labels yourself. |
Description: Update contexts so that time related setters and getters support time objects. Link to tracking Issue: #22010 Testing: unit tests for each new setter/getter Documentation: READMEs for `ottldatapoint`, `ottllog`, `ottlspan`, `ottlspanevent`.
Uh oh!
There was an error while loading. Please reload this page.
OTTL contexts are updated so that all time fields Getters return
time.Time
and Setters taketime.Time
. The accessor names should be updated to drop the time precision (_nano
).Context and fields that need updating:
Will also need to update all the
cache
accessors to be able to handle getting and settingtime.Time
andtime.Duration
. Instead of getting and setting apcommon.Map
it should be expressed as amap[string]string
.The text was updated successfully, but these errors were encountered: