Skip to content

datadog no resource serviceName #21525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rxg456 opened this issue May 6, 2023 · 6 comments
Closed

datadog no resource serviceName #21525

rxg456 opened this issue May 6, 2023 · 6 comments
Assignees
Labels
bug Something isn't working receiver/datadog

Comments

@rxg456
Copy link

rxg456 commented May 6, 2023

Component(s)

receiver/datadog

What happened?

Description

Currently in addResourceData service.name is not set. Its set in the span attributes. Because of this traces exported to backends like jaeger are appearing as empty-service-name

Steps to Reproduce

https://github.com/DataDog/dd-trace-php set env[DD_SERVICE] = my-app

receivers:
  datadog:
    endpoint: 0.0.0.0:8126
    read_timeout: 60s
processors:
  batch:
exporters:
  jaeger:
    endpoint: jaeger-collector:14250
    tls:
      insecure: true
service:
  pipelines:
    traces:
      receivers: [datadog]
      processors: [batch]
      exporters: [jaeger]

Expected Result

jaeger ui service name is my-app

Actual Result

jaeger ui service name is empty-service-name
image

Collector version

v0.76.1

Environment information

Environment

OS: Ubuntu 20.04

OpenTelemetry Collector configuration

receivers:
  datadog:
    endpoint: 0.0.0.0:8126
    read_timeout: 60s
processors:
  batch:
exporters:
  jaeger:
    endpoint: jaeger-collector:14250
    tls:
      insecure: true
service:
  pipelines:
    traces:
      receivers: [datadog]
      processors: [batch]
      exporters: [jaeger]

Log output

No response

Additional context

image

image

[receiver/datadog] not set at trace resource resulting in OTLPResourceNoServiceName

@rxg456 rxg456 added bug Something isn't working needs triage New item requiring triage labels May 6, 2023
@github-actions
Copy link
Contributor

github-actions bot commented May 6, 2023

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@atoulme atoulme removed the needs triage New item requiring triage label May 8, 2023
@MovieStoreGuy
Copy link
Contributor

This is interesting, when you're looking through the UI. Do you see the service.name being added to the span attributes?

@spearki
Copy link

spearki commented May 10, 2023

I saw the issue as well with a similar setup. I was able to work around it with the following processor, but I'm not familiar enough with the data model to understand why this worked. Something to do with the service name being set in individual spans, but not the resource?

processors:
  groupbyattrs:
    keys:
      - service.name

Edit: looks like there's another similar issue #21210

@MovieStoreGuy
Copy link
Contributor

Yeah, I am just looking at creating a PR for it now but it will be a breaking change.

@rxg456
Copy link
Author

rxg456 commented May 10, 2023

This is interesting, when you're looking through the UI. Do you see the service.name being added to the span attributes?

yes ,service.name has to be added to the span attributes
image

image

codeboten pushed a commit that referenced this issue May 15, 2023
…ions. (#21764)

Updating the translations for the datadog receiver to be more align with Otel Semantic Conventions to ensure integrations with other applications will work

**Link to tracking Issue:** 
Resolves issue #21525
And #21210
@MovieStoreGuy
Copy link
Contributor

Will be fixed in the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working receiver/datadog
Projects
None yet
Development

No branches or pull requests

4 participants