Skip to content

Commit 2954a49

Browse files
committed
Add 'physical writes direct' metric
1 parent 01f7bb1 commit 2954a49

File tree

8 files changed

+115
-0
lines changed

8 files changed

+115
-0
lines changed

receiver/oracledbreceiver/documentation.md

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -273,6 +273,14 @@ Number of reads directly from disk, bypassing the buffer cache
273273
| ---- | ----------- | ---------- | ----------------------- | --------- |
274274
| {reads} | Sum | Int | Cumulative | true |
275275
276+
### oracledb.physical_writes_direct
277+
278+
Number of writes directly from disk, bypassing the buffer cache
279+
280+
| Unit | Metric Type | Value Type | Aggregation Temporality | Monotonic |
281+
| ---- | ----------- | ---------- | ----------------------- | --------- |
282+
| {writes} | Sum | Int | Cumulative | true |
283+
276284
## Resource Attributes
277285
278286
| Name | Description | Values | Enabled |

receiver/oracledbreceiver/internal/metadata/generated_config.go

Lines changed: 4 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

receiver/oracledbreceiver/internal/metadata/generated_config_test.go

Lines changed: 2 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

receiver/oracledbreceiver/internal/metadata/generated_metrics.go

Lines changed: 64 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

receiver/oracledbreceiver/internal/metadata/generated_metrics_test.go

Lines changed: 17 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

receiver/oracledbreceiver/internal/metadata/testdata/config.yaml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,8 @@ all_set:
3939
enabled: true
4040
oracledb.physical_writes:
4141
enabled: true
42+
oracledb.physical_writes_direct:
43+
enabled: true
4244
oracledb.processes.limit:
4345
enabled: true
4446
oracledb.processes.usage:
@@ -102,6 +104,8 @@ none_set:
102104
enabled: false
103105
oracledb.physical_writes:
104106
enabled: false
107+
oracledb.physical_writes_direct:
108+
enabled: false
105109
oracledb.processes.limit:
106110
enabled: false
107111
oracledb.processes.usage:

receiver/oracledbreceiver/metadata.yaml

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -127,6 +127,15 @@ metrics:
127127
value_type: int
128128
input_type: string
129129
unit: "{writes}"
130+
oracledb.physical_writes_direct:
131+
description: Number of writes directly from disk, bypassing the buffer cache
132+
enabled: false
133+
sum:
134+
aggregation_temporality: cumulative
135+
monotonic: true
136+
value_type: int
137+
input_type: string
138+
unit: "{writes}"
130139
oracledb.user_commits:
131140
description: Number of user commits. When a user commits a transaction, the redo
132141
generated that reflects the changes made to database blocks must be written

receiver/oracledbreceiver/scraper.go

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,7 @@ const (
3434
physicalReads = "physical reads"
3535
physicalReadsDirect = "physical reads direct"
3636
physicalWrites = "physical writes"
37+
physicalWritesDirect = "physical writes direct"
3738
sessionLogicalReads = "session logical reads"
3839
cpuTime = "CPU used by this session"
3940
pgaMemory = "session pga memory"
@@ -110,6 +111,7 @@ func (s *oracleScraper) scrape(ctx context.Context) (pmetric.Metrics, error) {
110111
s.metricsBuilderConfig.Metrics.OracledbPhysicalReads.Enabled ||
111112
s.metricsBuilderConfig.Metrics.OracledbPhysicalReadsDirect.Enabled ||
112113
s.metricsBuilderConfig.Metrics.OracledbPhysicalWrites.Enabled ||
114+
s.metricsBuilderConfig.Metrics.OracledbPhysicalWritesDirect.Enabled ||
113115
s.metricsBuilderConfig.Metrics.OracledbLogicalReads.Enabled ||
114116
s.metricsBuilderConfig.Metrics.OracledbCPUTime.Enabled ||
115117
s.metricsBuilderConfig.Metrics.OracledbPgaMemory.Enabled ||
@@ -174,6 +176,11 @@ func (s *oracleScraper) scrape(ctx context.Context) (pmetric.Metrics, error) {
174176
if err != nil {
175177
scrapeErrors = append(scrapeErrors, err)
176178
}
179+
case physicalWritesDirect:
180+
err := s.mb.RecordOracledbPhysicalWritesDirectDataPoint(now, row["VALUE"])
181+
if err != nil {
182+
scrapeErrors = append(scrapeErrors, err)
183+
}
177184
case sessionLogicalReads:
178185
err := s.mb.RecordOracledbLogicalReadsDataPoint(now, row["VALUE"])
179186
if err != nil {

0 commit comments

Comments
 (0)