Skip to content

Commit 01f7bb1

Browse files
committed
Add 'physical writes' metric
1 parent 01245d6 commit 01f7bb1

File tree

8 files changed

+116
-0
lines changed

8 files changed

+116
-0
lines changed

receiver/oracledbreceiver/documentation.md

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -132,6 +132,14 @@ Number of physical reads
132132
| ---- | ----------- | ---------- | ----------------------- | --------- |
133133
| {reads} | Sum | Int | Cumulative | true |
134134
135+
### oracledb.physical_writes
136+
137+
Number of physical writes
138+
139+
| Unit | Metric Type | Value Type | Aggregation Temporality | Monotonic |
140+
| ---- | ----------- | ---------- | ----------------------- | --------- |
141+
| {writes} | Sum | Int | Cumulative | true |
142+
135143
### oracledb.processes.limit
136144
137145
Maximum limit of active processes, -1 if unlimited.

receiver/oracledbreceiver/internal/metadata/generated_config.go

Lines changed: 4 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

receiver/oracledbreceiver/internal/metadata/generated_config_test.go

Lines changed: 2 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

receiver/oracledbreceiver/internal/metadata/generated_metrics.go

Lines changed: 64 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

receiver/oracledbreceiver/internal/metadata/generated_metrics_test.go

Lines changed: 18 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

receiver/oracledbreceiver/internal/metadata/testdata/config.yaml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,8 @@ all_set:
3737
enabled: true
3838
oracledb.physical_reads_direct:
3939
enabled: true
40+
oracledb.physical_writes:
41+
enabled: true
4042
oracledb.processes.limit:
4143
enabled: true
4244
oracledb.processes.usage:
@@ -98,6 +100,8 @@ none_set:
98100
enabled: false
99101
oracledb.physical_reads_direct:
100102
enabled: false
103+
oracledb.physical_writes:
104+
enabled: false
101105
oracledb.processes.limit:
102106
enabled: false
103107
oracledb.processes.usage:

receiver/oracledbreceiver/metadata.yaml

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -118,6 +118,15 @@ metrics:
118118
value_type: int
119119
input_type: string
120120
unit: "{reads}"
121+
oracledb.physical_writes:
122+
description: Number of physical writes
123+
enabled: true
124+
sum:
125+
aggregation_temporality: cumulative
126+
monotonic: true
127+
value_type: int
128+
input_type: string
129+
unit: "{writes}"
121130
oracledb.user_commits:
122131
description: Number of user commits. When a user commits a transaction, the redo
123132
generated that reflects the changes made to database blocks must be written

receiver/oracledbreceiver/scraper.go

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,7 @@ const (
3333
userRollbacks = "user rollbacks"
3434
physicalReads = "physical reads"
3535
physicalReadsDirect = "physical reads direct"
36+
physicalWrites = "physical writes"
3637
sessionLogicalReads = "session logical reads"
3738
cpuTime = "CPU used by this session"
3839
pgaMemory = "session pga memory"
@@ -108,6 +109,7 @@ func (s *oracleScraper) scrape(ctx context.Context) (pmetric.Metrics, error) {
108109
s.metricsBuilderConfig.Metrics.OracledbUserRollbacks.Enabled ||
109110
s.metricsBuilderConfig.Metrics.OracledbPhysicalReads.Enabled ||
110111
s.metricsBuilderConfig.Metrics.OracledbPhysicalReadsDirect.Enabled ||
112+
s.metricsBuilderConfig.Metrics.OracledbPhysicalWrites.Enabled ||
111113
s.metricsBuilderConfig.Metrics.OracledbLogicalReads.Enabled ||
112114
s.metricsBuilderConfig.Metrics.OracledbCPUTime.Enabled ||
113115
s.metricsBuilderConfig.Metrics.OracledbPgaMemory.Enabled ||
@@ -167,6 +169,11 @@ func (s *oracleScraper) scrape(ctx context.Context) (pmetric.Metrics, error) {
167169
if err != nil {
168170
scrapeErrors = append(scrapeErrors, err)
169171
}
172+
case physicalWrites:
173+
err := s.mb.RecordOracledbPhysicalWritesDataPoint(now, row["VALUE"])
174+
if err != nil {
175+
scrapeErrors = append(scrapeErrors, err)
176+
}
170177
case sessionLogicalReads:
171178
err := s.mb.RecordOracledbLogicalReadsDataPoint(now, row["VALUE"])
172179
if err != nil {

0 commit comments

Comments
 (0)