Add 'physical reads direct' metric

Author: ccressent

receiver/oracledbreceiver/documentation.md

@@ -257,6 +257,14 @@ Number of times a current block was requested from the buffer cache.
 | ---- | ----------- | ---------- | ----------------------- | --------- |
 | {gets} | Sum | Int | Cumulative | true |
 
+### oracledb.physical_reads_direct
+
+Number of reads directly from disk, bypassing the buffer cache
+
+| Unit | Metric Type | Value Type | Aggregation Temporality | Monotonic |
+| ---- | ----------- | ---------- | ----------------------- | --------- |
+| {reads} | Sum | Int | Cumulative | true |
+
 ## Resource Attributes
 
 | Name | Description | Values | Enabled |

receiver/oracledbreceiver/generated_package_test.go

@@ -35,6 +35,8 @@ all_set:
       enabled: true
     oracledb.physical_reads:
       enabled: true
+    oracledb.physical_reads_direct:
+      enabled: true
     oracledb.processes.limit:
       enabled: true
     oracledb.processes.usage:
@@ -94,6 +96,8 @@ none_set:
       enabled: false
     oracledb.physical_reads:
       enabled: false
+    oracledb.physical_reads_direct:
+      enabled: false
     oracledb.processes.limit:
       enabled: false
     oracledb.processes.usage:

receiver/oracledbreceiver/internal/metadata/generated_config.go

@@ -109,6 +109,15 @@ metrics:
       value_type: int
       input_type: string
     unit: "{reads}"
+  oracledb.physical_reads_direct:
+    description: Number of reads directly from disk, bypassing the buffer cache
+    enabled: false
+    sum:
+      aggregation_temporality: cumulative
+      monotonic: true
+      value_type: int
+      input_type: string
+    unit: "{reads}"
   oracledb.user_commits:
     description: Number of user commits. When a user commits a transaction, the redo
       generated that reflects the changes made to database blocks must be written

receiver/oracledbreceiver/internal/metadata/generated_config_test.go

@@ -32,6 +32,7 @@ const (
 	userCommits             = "user commits"
 	userRollbacks           = "user rollbacks"
 	physicalReads           = "physical reads"
+	physicalReadsDirect     = "physical reads direct"
 	sessionLogicalReads     = "session logical reads"
 	cpuTime                 = "CPU used by this session"
 	pgaMemory               = "session pga memory"
@@ -106,6 +107,7 @@ func (s *oracleScraper) scrape(ctx context.Context) (pmetric.Metrics, error) {
 		s.metricsBuilderConfig.Metrics.OracledbUserCommits.Enabled ||
 		s.metricsBuilderConfig.Metrics.OracledbUserRollbacks.Enabled ||
 		s.metricsBuilderConfig.Metrics.OracledbPhysicalReads.Enabled ||
+		s.metricsBuilderConfig.Metrics.OracledbPhysicalReadsDirect.Enabled ||
 		s.metricsBuilderConfig.Metrics.OracledbLogicalReads.Enabled ||
 		s.metricsBuilderConfig.Metrics.OracledbCPUTime.Enabled ||
 		s.metricsBuilderConfig.Metrics.OracledbPgaMemory.Enabled ||
@@ -160,6 +162,11 @@ func (s *oracleScraper) scrape(ctx context.Context) (pmetric.Metrics, error) {
 				if err != nil {
 					scrapeErrors = append(scrapeErrors, err)
 				}
+			case physicalReadsDirect:
+				err := s.mb.RecordOracledbPhysicalReadsDirectDataPoint(now, row["VALUE"])
+				if err != nil {
+					scrapeErrors = append(scrapeErrors, err)
+				}
 			case sessionLogicalReads:
 				err := s.mb.RecordOracledbLogicalReadsDataPoint(now, row["VALUE"])
 				if err != nil {

receiver/oracledbreceiver/internal/metadata/generated_metrics.go

@@ -32,7 +32,7 @@ func TestScraper_ErrorOnStart(t *testing.T) {
 }
 
 var queryResponses = map[string][]metricRow{
-	statsSQL:        {{"NAME": enqueueDeadlocks, "VALUE": "18"}, {"NAME": exchangeDeadlocks, "VALUE": "88898"}, {"NAME": executeCount, "VALUE": "178878"}, {"NAME": parseCountTotal, "VALUE": "1999"}, {"NAME": parseCountHard, "VALUE": "1"}, {"NAME": userCommits, "VALUE": "187778888"}, {"NAME": userRollbacks, "VALUE": "1898979879789"}, {"NAME": physicalReads, "VALUE": "1887777"}, {"NAME": sessionLogicalReads, "VALUE": "189"}, {"NAME": cpuTime, "VALUE": "1887"}, {"NAME": pgaMemory, "VALUE": "1999887"}, {"NAME": dbBlockGets, "VALUE": "42"}, {"NAME": consistentGets, "VALUE": "78944"}},
+	statsSQL:        {{"NAME": enqueueDeadlocks, "VALUE": "18"}, {"NAME": exchangeDeadlocks, "VALUE": "88898"}, {"NAME": executeCount, "VALUE": "178878"}, {"NAME": parseCountTotal, "VALUE": "1999"}, {"NAME": parseCountHard, "VALUE": "1"}, {"NAME": userCommits, "VALUE": "187778888"}, {"NAME": userRollbacks, "VALUE": "1898979879789"}, {"NAME": physicalReads, "VALUE": "1887777"}, {"NAME": physicalReadsDirect, "VALUE": "31337"}, {"NAME": sessionLogicalReads, "VALUE": "189"}, {"NAME": cpuTime, "VALUE": "1887"}, {"NAME": pgaMemory, "VALUE": "1999887"}, {"NAME": dbBlockGets, "VALUE": "42"}, {"NAME": consistentGets, "VALUE": "78944"}},
 	sessionCountSQL: {{"VALUE": "1"}},
 	systemResourceLimitsSQL: {
 		{"RESOURCE_NAME": "processes", "CURRENT_UTILIZATION": "3", "MAX_UTILIZATION": "10", "INITIAL_ALLOCATION": "100", "LIMIT_VALUE": "100"},