-
Notifications
You must be signed in to change notification settings - Fork 1.5k
docs: Show edge rather than latest release #7717
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Show edge rather than latest release #7717
Conversation
e49fbeb
to
6daccb7
Compare
✅ Deploy Preview for openpolicyagent ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! 👍
@@ -37,7 +34,7 @@ export default function CurrentVersionNavbarItem({ ...props }) { | |||
<div className={styles.versionWrapper}> | |||
<DefaultNavbarItem | |||
{...props} | |||
label={`${latestVersion}`} | |||
label={"edge"} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will this also affect the archived docs for specific OPA releases, or that's generated/created some other way?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I kinda realised this was mostly not unhelpful unless we also had a way to set it. That will be used in the opa-docs repo, but this allows the site to be built with a version set.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(So I have another commit to update this)
6daccb7
to
33b4ebe
Compare
Docs are updated as we push to main, this means the version is not the latest, but rather the edge version. This is to avoid confusion while still showing fixes to the docs site as we make them, since it's still an active area of development after we released the new version. Signed-off-by: Charlie Egan <[email protected]>
This will be used to set the version in the navbar item on versioned deploys of the site. Signed-off-by: Charlie Egan <[email protected]>
33b4ebe
to
220210c
Compare
✅ Deploy Preview for openpolicyagent ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Docs are updated as we push to main, this means the version is not the latest, but rather the edge version. This is to avoid confusion while still showing fixes to the docs site as we make them, since it's still an active area of development after we released the new version.
I have left in the component as we will want to make it so that this shows the latest tag when building an archived deployment and will use this component for that, but for now, it's just always shows edge.