docs: Improve explanations for initial examples #7677
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We had some feedback that the initial examples in the docs were not clear enough and needed some more explanation. Signed-off-by: Charlie Egan <[email protected]>
✅ Deploy Preview for openpolicyagent ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
anderseknert
reviewed
Jun 9, 2025
There was a problem hiding this comment.
Thanks! Does this really address the issue described though?
evaluates to True even while the fort two network .public values are false. I really miss some explanation here.
I take that to mean they did not understand how multiple incremental rules are OR'ed, and rather expected them to be AND'ed here (as the expectation was that one false result would fail eval)
|
I'd tried to address that with the #or comments in this new code but perhaps a more prominent call out is needed? |
|
I have added a note in 406e16a |
anderseknert
approved these changes
Jun 9, 2025
Signed-off-by: Charlie Egan <[email protected]>
charlieegan3
force-pushed
the
docs-index-examples-touchup
branch
from
406e16a to
58a3e29
Compare
|
Thanks Anders! |
charlieegan3
pushed a commit
to charlieegan3/opa
that referenced
this pull request
Jun 10, 2025
This is following some additional feedback from the reporter of open-policy-agent#7677 Signed-off-by: Charlie Egan <[email protected]>
charlieegan3
pushed a commit
to charlieegan3/opa
that referenced
this pull request
Jun 10, 2025
This is following some additional feedback from the reporter of open-policy-agent#7677 Signed-off-by: Charlie Egan <[email protected]>
charlieegan3
pushed a commit
that referenced
this pull request
Jun 10, 2025
This is following some additional feedback from the reporter of #7677 Signed-off-by: Charlie Egan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had some feedback that the initial examples in the docs were not clear enough and needed some more explanation.
