v4.0.x, oshmem:ucx, fix race condition and add context recycling #7215
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gpaulsen
suggested changes
Dec 9, 2019
Member
gpaulsen
left a comment
gpaulsen
left a comment
There was a problem hiding this comment.
Is this a cherry-pick of ebb985d ? If so, can you please redo this Pull request by using -x flag to git cherry-pick -x so that git includes the "Cherry Picked From" comment in the commit message? This helps up keep track of commits in the future.
1) Race condition: Do not add private contexts to active list. Private contexts are only visible to the user. 2) Recycled contexts: Destroyed contexts are put on an idle list until finalize, continuous context creation will lead to oom condition. Instead, check if context from idle list meets new context requirements and reuse it. Co-authored with: Artem Y. Polyakov <[email protected]>, Manjunath Gorentla Venkata <[email protected]> Signed-off-by: Tomislav Janjusic <[email protected]> (cherry picked from commit bd7cdf7)
janjust
force-pushed
the
v4.0.x-oshmem-context-fixes
branch
from
915e303 to
b84074d
Compare
Contributor
Author
|
@gpaulsen done |
gpaulsen
approved these changes
Dec 10, 2019
Member
gpaulsen
left a comment
gpaulsen
left a comment
There was a problem hiding this comment.
Thanks for adding the -x to cherry pick to help with keeping track of things.
Member
|
bot:ompi:retest |
Contributor
Author
|
@artpol84 , please approve if no objections |
artpol84
approved these changes
Dec 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Private contexts are only visible to the user.
finalize, continuous context creation will lead to oom condition.
Instead, check if context from idle list meets new context requirements
and reuse it.
Co-authored with: Artem Y. Polyakov [email protected],
Manjunath Gorentla Venkata [email protected]
Signed-off-by: Tomislav Janjusic [email protected]