pml/ucx: correctly handle zero size datatypes #7161
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zero-size derived datatypes are now flagged as OPAL_DATATYPE_FLAG_CONTIGUOUS so update mca_pml_ucx_init_datatype() to correctly handle them. Since 'size' is a 'size_t', the assertion can simply be removed. Signed-off-by: Gilles Gouaillardet <[email protected]> (cherry picked from commit 33361aa)
Contributor
Member
|
@ggouaillardet is right, the predefined datatypes are not marked as contiguous in the v4.0.x. |
Member
Author
|
I'm going to try pulling in 3522916, and and retesting the reproducer. We may end up just closing this. Is this desirable on v4.0.x? |
Member
Author
|
I'm closing as un-needed in v4.0.x |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
zero-size derived datatypes are now flagged as OPAL_DATATYPE_FLAG_CONTIGUOUS
so update mca_pml_ucx_init_datatype() to correctly handle them.
Since 'size' is a 'size_t', the assertion can simply be removed.
Signed-off-by: Gilles Gouaillardet [email protected]
(cherry picked from commit 33361aa)