Skip to content

Conversation

rajeshgangireddy
Copy link
Contributor

@rajeshgangireddy rajeshgangireddy commented May 6, 2025

Summary

Removes some visual prompting references in the code - mostly related to the latest benchmark.

How to test

Checklist

  • I have added unit tests to cover my changes.​
  • I have added integration tests to cover my changes.​
  • I have ran e2e tests and there is no issues.
  • I have added the description of my changes into CHANGELOG in my target branch (e.g., CHANGELOG in develop).​
  • I have updated the documentation in my target branch accordingly (e.g., documentation in develop).
  • I have linked related issues.

License

  • I submit my code changes under the same Apache License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below).
# Copyright (C) 2025 Intel Corporation
# SPDX-License-Identifier: Apache-2.0

Need to add the line in changelog after PR
@github-actions github-actions bot added TEST Any changes in tests DOC Improvements or additions to documentation labels May 6, 2025
Copy link
Contributor

@ashwinvaidya17 ashwinvaidya17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can see .DS_Store files. Maybe something needs to be updated in your gitignore

@ashwinvaidya17
Copy link
Contributor

Rest looks good to me.

@rajeshgangireddy rajeshgangireddy changed the title Remove traces of visual prompting 🗑️ Remove traces of visual prompting May 6, 2025
sovrasov
sovrasov previously approved these changes May 6, 2025
@rajeshgangireddy
Copy link
Contributor Author

I can see .DS_Store files. Maybe something needs to be updated in your gitignore

Removed them.
And updated the gitignore file as well.

@rajeshgangireddy rajeshgangireddy requested review from ashwinvaidya17, sovrasov and Copilot and removed request for djdameln May 7, 2025 07:35
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes all traces of the visual prompting functionality from the codebase. The key changes include:

  • Removing visual prompting references from tests and source files.
  • Updating test descriptions to correctly reflect keypoint detection benchmarks.
  • Cleaning up historical entries and documentation to eliminate visual prompting.

Reviewed Changes

Copilot reviewed 7 out of 11 changed files in this pull request and generated no comments.

Show a summary per file
File Description
tests/perf_v2/summary.py Removed the visual prompting mapping entry.
tests/perf_v2/init.py Eliminated visual prompting from imports and mappings.
tests/perf/test_keypoint_detection.py Adjusted test docstrings to reference keypoint detection instead of visual prompting.
tests/perf/history/summary.ipynb Removed visual prompting sections and links.
src/otx/algo/init.py Removed visual prompting module reference.
CHANGELOG.md Updated removed items section to include visual prompting removal.
Files not reviewed (4)
  • docs/source/guide/get_started/cli_commands.rst: Language not supported
  • src/otx/tools/templates/visual_prompting/configuration.yaml: Language not supported
  • src/otx/tools/templates/visual_prompting/sam_tiny_vit/template.yaml: Language not supported
  • src/otx/tools/templates/visual_prompting/sam_vit_b/template.yaml: Language not supported

Copy link
Contributor

@ashwinvaidya17 ashwinvaidya17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@kprokofi kprokofi merged commit dd14740 into open-edge-platform:develop May 7, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DOC Improvements or additions to documentation TEST Any changes in tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants