-
Notifications
You must be signed in to change notification settings - Fork 460
🗑️ Remove traces of visual prompting #4370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🗑️ Remove traces of visual prompting #4370
Conversation
Need to add the line in changelog after PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can see .DS_Store files. Maybe something needs to be updated in your gitignore
Rest looks good to me. |
Removed them. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR removes all traces of the visual prompting functionality from the codebase. The key changes include:
- Removing visual prompting references from tests and source files.
- Updating test descriptions to correctly reflect keypoint detection benchmarks.
- Cleaning up historical entries and documentation to eliminate visual prompting.
Reviewed Changes
Copilot reviewed 7 out of 11 changed files in this pull request and generated no comments.
Show a summary per file
File | Description |
---|---|
tests/perf_v2/summary.py | Removed the visual prompting mapping entry. |
tests/perf_v2/init.py | Eliminated visual prompting from imports and mappings. |
tests/perf/test_keypoint_detection.py | Adjusted test docstrings to reference keypoint detection instead of visual prompting. |
tests/perf/history/summary.ipynb | Removed visual prompting sections and links. |
src/otx/algo/init.py | Removed visual prompting module reference. |
CHANGELOG.md | Updated removed items section to include visual prompting removal. |
Files not reviewed (4)
- docs/source/guide/get_started/cli_commands.rst: Language not supported
- src/otx/tools/templates/visual_prompting/configuration.yaml: Language not supported
- src/otx/tools/templates/visual_prompting/sam_tiny_vit/template.yaml: Language not supported
- src/otx/tools/templates/visual_prompting/sam_vit_b/template.yaml: Language not supported
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
Summary
Removes some visual prompting references in the code - mostly related to the latest benchmark.
How to test
Checklist
License
Feel free to contact the maintainers if that's a concern.