Skip to content

fix can not set max width #2081

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 6, 2025
Merged

fix can not set max width #2081

merged 1 commit into from
Jun 6, 2025

Conversation

spartan-vutrannguyen
Copy link
Contributor

@spartan-vutrannguyen spartan-vutrannguyen commented Jun 6, 2025

Description

(Should merge after #2080 )

  • Fixed a bug that prevented users from setting min/max values for dimension inputs.

Related Issues

Type of Change

  • Bug fix
  • New feature
  • Documentation update
  • Release
  • Refactor
  • Other (please describe):

Testing

Screenshots (if applicable)

Additional Notes


Important

Fixes bug in use-dimension-control.ts by correcting key format for min/max dimension values to enable setting them.

  • Bug Fix:
    • Corrects key format for accessing min/max dimension values in use-dimension-control.ts.
    • Changes maxDimensionKey and minDimensionKey to use kebab-case (max-width, min-width) instead of camelCase (maxWidth, minWidth).
  • Behavior:
    • Fixes issue preventing setting of min/max values for dimension inputs.
    • Ensures correct style properties are accessed and updated.

This description was created by Ellipsis for c480f5d. You can customize this summary. It will automatically update as commits are pushed.

Copy link

vercel bot commented Jun 6, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 6, 2025 2:04pm
web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 6, 2025 2:04pm

Copy link

supabase bot commented Jun 6, 2025

This pull request has been ignored for the connected project wowaemfasoptxrdjhilu because there are no changes detected in apps/backend/supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.


Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important

Looks good to me! 👍

Reviewed everything up to c480f5d in 48 seconds. Click for details.
  • Reviewed 27 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 3 draft comments. View those below.
  • Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. apps/web/client/src/app/project/[id]/_components/editor-bar/hooks/use-dimension-control.ts:52
  • Draft comment:
    Good inline comment clarifying why definedStyles is used.
  • Reason this comment was not posted:
    Confidence changes required: 0% <= threshold 50% None
2. apps/web/client/src/app/project/[id]/_components/editor-bar/hooks/use-dimension-control.ts:61
  • Draft comment:
    Using hyphenated key ('max-width') ensures proper lookup from definedStyles.
  • Reason this comment was not posted:
    Confidence changes required: 0% <= threshold 50% None
3. apps/web/client/src/app/project/[id]/_components/editor-bar/hooks/use-dimension-control.ts:66
  • Draft comment:
    Using hyphenated key ('min-width') correctly retrieves the min value from definedStyles.
  • Reason this comment was not posted:
    Confidence changes required: 0% <= threshold 50% None

Workflow ID: wflow_i8xzpcScLsfxmUCd

You can customize Ellipsis by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.

@Kitenite Kitenite merged commit 9e2f96a into main Jun 6, 2025
4 checks passed
@Kitenite Kitenite deleted the fix/can-not-set-max-width branch June 6, 2025 16:50
Kitenite pushed a commit that referenced this pull request Jun 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug] Min and max width are reset to 0 after being set and clicking outside
2 participants