fix(halo/attest): verify votes before proposing #2482
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corverroos
requested review from
devbugging,
chmllr and
kc1116
as code owners
kc1116
approved these changes
Nov 14, 2024
chmllr
approved these changes
Nov 14, 2024
corverroos
force-pushed
the
corver/verifyproposedvotes
branch
from
211e8a6 to
1851c3a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Verify (and discard) invalid votes before proposing. This is required since VerifyVoteExtension isn't always called, so LastLocalCommit may contain invalid votes.
issue: #2460