Skip to content

fix bug when account is created and deleted in one ac gap #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
KamiD merged 4 commits into from
Apr 19, 2023
Merged

fix bug when account is created and deleted in one ac gap #97

KamiD merged 4 commits into from
Apr 19, 2023

Conversation

@giskook
Copy link
Contributor

@giskook giskook commented Apr 5, 2023

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md

  • Reviewed Files changed in the github PR explorer

For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge PR #XYZ: [title]" (coding standards)

@giskook giskook changed the title deal with the situation when a account is deleted in a ac gap deal with the situation when account is created and deleted in a ac gap Apr 6, 2023
@giskook giskook changed the title deal with the situation when account is created and deleted in a ac gap fix bug when account is created and deleted in one ac gap Apr 6, 2023
@giskook giskook marked this pull request as ready for review April 11, 2023 02:03
@giskook giskook requested review from cwbhhjl, lyh169 and zjg555543 April 11, 2023 02:03
cwbhhjl
cwbhhjl previously approved these changes Apr 12, 2023
View reviewed changes
@KamiD KamiD merged commit 12e5bde into dev Apr 19, 2023
giskook added a commit that referenced this pull request May 23, 2023
@giskook
fix bug when account is created and deleted in one ac gap (#97)
09f5abe 
* deal with the situation when a account is deleted by a ac gap

* add unittest

* use syncpool to calc addrhash when update snapaccount

* rename ut name
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cwbhhjl cwbhhjl cwbhhjl approved these changes

@zjg555543 zjg555543 zjg555543 approved these changes

+1 more reviewer

@lyh169 lyh169 lyh169 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@giskook @cwbhhjl @zjg555543 @lyh169 @KamiD