Skip to content

Conversation

@giskook
Copy link
Contributor

@giskook giskook commented Jun 16, 2023

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md

  • Reviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge PR #XYZ: [title]" (coding standards)

@giskook giskook requested a review from zjg555543 June 16, 2023 03:15
@codecov-commenter
Copy link

codecov-commenter commented Jun 16, 2023

Codecov Report

Merging #180 (87aa223) into dev (8391f54) will decrease coverage by 0.01%.
The diff coverage is n/a.

❗ Current head 87aa223 differs from pull request most recent head 5204f73. Consider uploading reports for the commit 5204f73 to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##              dev     #180      +/-   ##
==========================================
- Coverage   34.53%   34.53%   -0.01%     
==========================================
  Files         429      429              
  Lines       44762    44762              
==========================================
- Hits        15459    15457       -2     
- Misses      28155    28156       +1     
- Partials     1148     1149       +1     

see 1 file with indirect coverage changes

@KamiD KamiD merged commit 66ce293 into dev Jun 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants