Skip to content

Conversation

@FineKe
Copy link
Contributor

@FineKe FineKe commented Jun 15, 2023

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md

  • Reviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge PR #XYZ: [title]" (coding standards)

@FineKe FineKe requested a review from chengzhinei June 15, 2023 07:32
@codecov-commenter
Copy link

codecov-commenter commented Jun 15, 2023

Codecov Report

Merging #176 (fe462d8) into dev (8306798) will not change coverage.
The diff coverage is n/a.

❗ Current head fe462d8 differs from pull request most recent head 80fa5c9. Consider uploading reports for the commit 80fa5c9 to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff           @@
##              dev     #176   +/-   ##
=======================================
  Coverage   34.53%   34.53%           
=======================================
  Files         429      429           
  Lines       44762    44762           
=======================================
  Hits        15457    15457           
  Misses      28156    28156           
  Partials     1149     1149           

chengzhinei
chengzhinei previously approved these changes Jun 15, 2023
@KamiD KamiD merged commit 8391f54 into dev Jun 15, 2023
@chengzhinei chengzhinei deleted the kefan/block_height branch August 2, 2023 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants