Skip to content

Conversation

@KamiD
Copy link
Member

@KamiD KamiD commented Jun 6, 2023

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md

  • Reviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge PR #XYZ: [title]" (coding standards)

@codecov-commenter
Copy link

Codecov Report

Merging #169 (4170196) into dev (e6ca215) will decrease coverage by 4.00%.
The diff coverage is n/a.

❗ Current head 4170196 differs from pull request most recent head 124dbdd. Consider uploading reports for the commit 124dbdd to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##              dev     #169      +/-   ##
==========================================
- Coverage   34.21%   30.22%   -4.00%     
==========================================
  Files         423       54     -369     
  Lines       44410     5718   -38692     
==========================================
- Hits        15197     1728   -13469     
+ Misses      28104     3814   -24290     
+ Partials     1109      176     -933     

see 369 files with indirect coverage changes

@KamiD KamiD merged commit c836620 into dev Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants