Skip to content

Conversation

@lyh169
Copy link
Contributor

@lyh169 lyh169 commented Jun 1, 2023

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md

  • Reviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge PR #XYZ: [title]" (coding standards)

@lyh169
Copy link
Contributor Author

lyh169 commented Jun 1, 2023

@codecov-commenter
Copy link

codecov-commenter commented Jun 1, 2023

Codecov Report

Merging #162 (6e9818a) into dev (ed0f7b3) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

❗ Current head 6e9818a differs from pull request most recent head e5b2831. Consider uploading reports for the commit e5b2831 to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##              dev     #162      +/-   ##
==========================================
- Coverage   34.22%   34.22%   -0.01%     
==========================================
  Files         423      423              
  Lines       44396    44397       +1     
==========================================
  Hits        15193    15193              
- Misses      28094    28095       +1     
  Partials     1109     1109              
Impacted Files Coverage Δ
app/node_mode.go 8.53% <0.00%> (-0.11%) ⬇️

@KamiD KamiD merged commit 3dd4d46 into dev Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants