Skip to content

Conversation

@lyh169
Copy link
Contributor

@lyh169 lyh169 commented May 30, 2023

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md

  • Reviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge PR #XYZ: [title]" (coding standards)

@codecov-commenter
Copy link

codecov-commenter commented May 30, 2023

Codecov Report

Merging #153 (87eb521) into dev (0c08130) will increase coverage by 0.00%.
The diff coverage is 23.80%.

❗ Current head 87eb521 differs from pull request most recent head e12bd01. Consider uploading reports for the commit e12bd01 to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff           @@
##              dev     #153   +/-   ##
=======================================
  Coverage   34.21%   34.22%           
=======================================
  Files         423      424    +1     
  Lines       44410    44451   +41     
=======================================
+ Hits        15197    15214   +17     
- Misses      28104    28124   +20     
- Partials     1109     1113    +4     
Impacted Files Coverage Δ
x/params/querier.go 0.00% <0.00%> (ø)
x/params/types/params.go 0.00% <0.00%> (ø)
x/params/types/params_gas.go 0.00% <0.00%> (ø)
app/app.go 81.78% <50.00%> (-0.27%) ⬇️
x/params/keeper.go 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

zjg555543
zjg555543 previously approved these changes May 31, 2023
BananaLF
BananaLF previously approved these changes May 31, 2023
@lyh169 lyh169 dismissed stale reviews from BananaLF and zjg555543 via ebdd789 June 5, 2023 01:47
@KamiD KamiD merged commit c3a8a69 into dev Jun 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants