Skip to content

Conversation

@chengzhinei
Copy link
Contributor

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md

  • Reviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge PR #XYZ: [title]" (coding standards)

@codecov-commenter
Copy link

codecov-commenter commented May 30, 2023

Codecov Report

Merging #152 (217186c) into dev (cc562bf) will increase coverage by 0.00%.
The diff coverage is n/a.

❗ Current head 217186c differs from pull request most recent head 02d3b90. Consider uploading reports for the commit 02d3b90 to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff           @@
##              dev     #152   +/-   ##
=======================================
  Coverage   34.21%   34.21%           
=======================================
  Files         423      423           
  Lines       44399    44399           
=======================================
+ Hits        15191    15193    +2     
+ Misses      28097    28096    -1     
+ Partials     1111     1110    -1     

see 1 file with indirect coverage changes

@chengzhinei chengzhinei changed the title use kv for delete use kv for dds May 31, 2023
@chengzhinei chengzhinei marked this pull request as ready for review May 31, 2023 07:57
giskook
giskook previously approved these changes Jun 2, 2023
@KamiD KamiD merged commit d736de5 into dev Jun 2, 2023
@chengzhinei chengzhinei deleted the fsc/dds-kv branch August 2, 2023 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants