Skip to content

Conversation

@scf0220
Copy link
Contributor

@scf0220 scf0220 commented May 16, 2023

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md

  • Reviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge PR #XYZ: [title]" (coding standards)

@codecov-commenter
Copy link

codecov-commenter commented May 16, 2023

Codecov Report

Merging #130 (18185f1) into dev (ea5b5ab) will increase coverage by 0.01%.
The diff coverage is 69.56%.

❗ Current head 18185f1 differs from pull request most recent head 49de278. Consider uploading reports for the commit 49de278 to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##              dev     #130      +/-   ##
==========================================
+ Coverage   34.18%   34.19%   +0.01%     
==========================================
  Files         423      423              
  Lines       44252    44246       -6     
==========================================
+ Hits        15127    15130       +3     
+ Misses      28026    28017       -9     
  Partials     1099     1099              
Impacted Files Coverage Δ
app/app.go 82.52% <0.00%> (-0.35%) ⬇️
app/rpc/namespaces/eth/api.go 0.00% <0.00%> (ø)
x/evm/watcher/db.go 76.36% <ø> (ø)
x/wasm/keeper/querier.go 70.04% <0.00%> (ø)
x/wasm/simulate.go 0.00% <0.00%> (ø)
x/wasm/keeper/keeper.go 79.51% <91.17%> (+0.08%) ⬆️
x/wasm/keeper/keeper_mpt.go 100.00% <100.00%> (ø)

@KamiD KamiD merged commit 54c87fd into dev May 24, 2023
@KamiD KamiD deleted the scf/fq-fix branch May 24, 2023 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants