Skip to content

Conversation

@KamiD
Copy link
Member

@KamiD KamiD commented May 16, 2023

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md

  • Reviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge PR #XYZ: [title]" (coding standards)

@codecov-commenter
Copy link

codecov-commenter commented May 16, 2023

Codecov Report

Merging #129 (0a35a9f) into dev (1143a8f) will decrease coverage by 0.01%.
The diff coverage is n/a.

❗ Current head 0a35a9f differs from pull request most recent head 5946384. Consider uploading reports for the commit 5946384 to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##              dev     #129      +/-   ##
==========================================
- Coverage   34.18%   34.17%   -0.01%     
==========================================
  Files         423      423              
  Lines       44252    44252              
==========================================
- Hits        15127    15125       -2     
- Misses      28026    28027       +1     
- Partials     1099     1100       +1     

see 1 file with indirect coverage changes

@KamiD KamiD merged commit ea5b5ab into dev May 16, 2023
giskook pushed a commit that referenced this pull request May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants