Skip to content

Conversation

@chengzhinei
Copy link
Contributor

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md

  • Reviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge PR #XYZ: [title]" (coding standards)

@codecov-commenter
Copy link

codecov-commenter commented May 15, 2023

Codecov Report

Merging #128 (7f76525) into dev (9b9edd8) will decrease coverage by 4.09%.
The diff coverage is n/a.

❗ Current head 7f76525 differs from pull request most recent head 8c25974. Consider uploading reports for the commit 8c25974 to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##              dev     #128      +/-   ##
==========================================
- Coverage   34.20%   30.11%   -4.09%     
==========================================
  Files         423       54     -369     
  Lines       44310     5675   -38635     
==========================================
- Hits        15155     1709   -13446     
+ Misses      28053     3791   -24262     
+ Partials     1102      175     -927     

see 369 files with indirect coverage changes

@KamiD KamiD merged commit a8ffad7 into dev May 16, 2023
@KamiD KamiD deleted the fsc/gc-opt branch May 16, 2023 00:50
giskook pushed a commit that referenced this pull request May 23, 2023
* opt gc

* revert

* use comment

* use comment

* use for delete

* use for delete

* fix fmt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants