Skip to content

Conversation

@LeoGuo621
Copy link
Contributor

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md

  • Reviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge PR #XYZ: [title]" (coding standards)

@LeoGuo621
Copy link
Contributor Author

double commit: okx/exchain#3125

@LeoGuo621 LeoGuo621 requested a review from scf0220 May 9, 2023 11:03
@codecov-commenter
Copy link

codecov-commenter commented May 9, 2023

Codecov Report

Merging #119 (5b7367f) into dev (26e49fe) will decrease coverage by 0.01%.
The diff coverage is n/a.

❗ Current head 5b7367f differs from pull request most recent head f4b48ea. Consider uploading reports for the commit f4b48ea to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##              dev     #119      +/-   ##
==========================================
- Coverage   34.20%   34.19%   -0.01%     
==========================================
  Files         423      423              
  Lines       44310    44310              
==========================================
- Hits        15155    15153       -2     
- Misses      28053    28054       +1     
- Partials     1102     1103       +1     

see 1 file with indirect coverage changes

@LeoGuo621 LeoGuo621 requested a review from KamiD May 9, 2023 12:36
@KamiD KamiD merged commit ea26ac2 into dev May 15, 2023
giskook pushed a commit that referenced this pull request May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants