Skip to content

Conversation

@zjg555543
Copy link
Contributor

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md

  • Reviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge PR #XYZ: [title]" (coding standards)

@zjg555543 zjg555543 changed the title fix gov proposal cli fix gov proposal cli crash May 9, 2023
@codecov-commenter
Copy link

codecov-commenter commented May 9, 2023

Codecov Report

Merging #117 (10d8746) into dev (418fd81) will decrease coverage by 3.90%.
The diff coverage is n/a.

❗ Current head 10d8746 differs from pull request most recent head e5c323a. Consider uploading reports for the commit e5c323a to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##              dev     #117      +/-   ##
==========================================
- Coverage   34.18%   30.28%   -3.90%     
==========================================
  Files         423       54     -369     
  Lines       44254     5660   -38594     
==========================================
- Hits        15127     1714   -13413     
+ Misses      28028     3773   -24255     
+ Partials     1099      173     -926     

see 369 files with indirect coverage changes

@zjg555543 zjg555543 requested a review from giskook May 10, 2023 09:09
@KamiD KamiD merged commit 4d71bb3 into dev Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants