Skip to content

Conversation

@fatcat22
Copy link
Contributor

…pect height

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md

  • Reviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge PR #XYZ: [title]" (coding standards)

@codecov-commenter
Copy link

codecov-commenter commented Apr 28, 2023

Codecov Report

Merging #106 (f6dbc87) into dev (12168ea) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

❗ Current head f6dbc87 differs from pull request most recent head ee77e58. Consider uploading reports for the commit ee77e58 to get more accurate results

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##              dev     #106      +/-   ##
==========================================
- Coverage   34.39%   34.37%   -0.03%     
==========================================
  Files         419      419              
  Lines       43349    43341       -8     
==========================================
- Hits        14911    14899      -12     
- Misses      27365    27367       +2     
- Partials     1073     1075       +2     
Impacted Files Coverage Δ
x/params/upgrade_executor.go 89.47% <100.00%> (-3.39%) ⬇️

... and 1 file with indirect coverage changes

@xiangjianmeng xiangjianmeng merged commit 07f12e6 into dev May 10, 2023
@xiangjianmeng xiangjianmeng deleted the fix-upgrade-proposal branch May 10, 2023 14:22
giskook pushed a commit that referenced this pull request May 23, 2023
* dev: upgrade proposal vote and effective after height greater than expect height

* fix test

---------

Co-authored-by: fatcat22 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants