Skip to content
This repository was archived by the owner on Aug 23, 2025. It is now read-only.

Conversation

@chengzhinei
Copy link
Contributor

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md

  • Reviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge PR #XYZ: [title]" (coding standards)

FlagCsTimeoutPrecommit = "consensus.timeout_precommit"
FlagCsTimeoutPrecommitDelta = "consensus.timeout_precommit_delta"
FlagCsTimeoutCommit = "consensus.timeout_commit"
FlagEnableConsensusIPWhitelist = "consensus.enable_ip_whitelist"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

p2p.enable_ip_whitelist,p2p.ip_whiteklist much better

BananaLF
BananaLF previously approved these changes Jul 9, 2024
@xiangjianmeng xiangjianmeng merged commit 88f26b4 into dev Jul 11, 2024
@xiangjianmeng xiangjianmeng deleted the fsc/consensus-ip branch July 11, 2024 07:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants