Skip to content
This repository was archived by the owner on Aug 23, 2025. It is now read-only.

Conversation

@zjg555543
Copy link
Contributor

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md

  • Reviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge PR #XYZ: [title]" (coding standards)

@codecov-commenter
Copy link

codecov-commenter commented Jan 15, 2024

Codecov Report

Attention: 36 lines in your changes are missing coverage. Please review.

Comparison is base (f1ce92c) 36.53% compared to head (780d3d3) 36.50%.
Report is 2 commits behind head on dev.

❗ Current head 780d3d3 differs from pull request most recent head f94ad3f. Consider uploading reports for the commit f94ad3f to get more accurate results

Files Patch % Lines
app/rpc/namespaces/eth/api.go 0.00% 35 Missing ⚠️
x/staking/keeper/keeper_ibc_adapter.go 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #3284      +/-   ##
==========================================
- Coverage   36.53%   36.50%   -0.03%     
==========================================
  Files         446      446              
  Lines       46869    46904      +35     
==========================================
  Hits        17124    17124              
- Misses      28472    28507      +35     
  Partials     1273     1273              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

ylsGit
ylsGit previously approved these changes Jan 17, 2024
@KamiD KamiD merged commit 580a0d9 into dev Jan 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants