Skip to content
This repository was archived by the owner on Aug 23, 2025. It is now read-only.

Conversation

@ilovers
Copy link
Contributor

@ilovers ilovers commented Dec 13, 2023

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md

  • Reviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge PR #XYZ: [title]" (coding standards)

@codecov-commenter
Copy link

codecov-commenter commented Dec 13, 2023

Codecov Report

Attention: 35 lines in your changes are missing coverage. Please review.

Comparison is base (f1ce92c) 36.53% compared to head (21dfcac) 36.50%.

❗ Current head 21dfcac differs from pull request most recent head 0161331. Consider uploading reports for the commit 0161331 to get more accurate results

Files Patch % Lines
app/rpc/namespaces/eth/api.go 0.00% 35 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #3273      +/-   ##
==========================================
- Coverage   36.53%   36.50%   -0.03%     
==========================================
  Files         446      446              
  Lines       46869    46904      +35     
==========================================
  Hits        17124    17124              
- Misses      28472    28507      +35     
  Partials     1273     1273              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xiangjianmeng xiangjianmeng merged commit 345ad1d into dev Dec 13, 2023
@xiangjianmeng xiangjianmeng deleted the dev-rpc-limit branch December 13, 2023 13:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants